bugSTUMP - Bugs: bug #61983, Strip/rename pre-existing...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #61983: Strip/rename pre-existing Injection-Date, Injection-Info, Xref headers

Submitter:  Rayner Lucas <rayner>
Submitted:  Wed 02 Feb 2022 09:55:34 PM UTC
   
 
Category:  None Severity:  4 - Important
Item Group:  None Status:  Ready For Test
Privacy:  Public Assigned to:  rayner
Open/Closed:  Open Planned Release:  2.6

Thu 06 Oct 2022 01:53:55 AM UTC, comment #5: 

Pushed some changes that do the following:

- Remove any existing XRef header. [RFC5537]
- Prepend "X-Original-" to any existing Injection-Date or Injection-Info headers. [RFC5537]
- Remove any Disposition-Notification-To header. [RFC8098]
- Prepend "Old-" to any existing NNTP-Posting-Host or NNTP-Posting-Date header (these are non-standard headers that are obsoleted by Injection-Info and Injection-Date, but possibly some news servers might still add them)

Also, the format string for the Date header had a hard-coded time zone which is usually going to be wrong, so I changed it to use the local offset as per RFC5322.

Changes are on branch: 61983-injection-headers

Rayner Lucas <rayner>
Group administrator
Mon 07 Feb 2022 06:18:24 PM UTC, comment #4: 

Thanks for that suggestion, Paul. It does look like the logical place to add a fix for this issue.

If we want to rename the offending headers rather than just deleting them, we can do this using the -R flag to formail.

Rayner Lucas <rayner>
Group administrator
Mon 07 Feb 2022 02:38:43 PM UTC, comment #3: 

comment #2:

> The bin/processApproved script runs a formail command which can use -I (delete) or -i (pre-pend with X-) arguments to transform the headers in the article before posting.  Adding the following lines to this command would implement the fix to this item:
>
>             -i "NNTP-Posting-Date:"                     \
>             -i "NNTP-Posting-Host:"                     \
>             -i "X-Complaints-To:"                       \
>             -i "Injection-Date:"                        \
>             -i "Injection-Info:"                        \
>             -i "X-Injection-Date:"                      \
>             -i "X-Injection-Info:"                      \


Perhaps it might be better to prepend "X-Original-" instead of "X-"?  I have often seen "X-Original-" in the wild when headers get rewritten, but simply adding "X-" loses some important semantics.

Tristan Miller <psychonaut>
Group administrator
Sat 05 Feb 2022 03:05:33 AM UTC, comment #2: 

The bin/processApproved script runs a formail command which can use -I (delete) or -i (pre-pend with X-) arguments to transform the headers in the article before posting.  Adding the following lines to this command would implement the fix to this item:

            -i "NNTP-Posting-Date:"                     \
            -i "NNTP-Posting-Host:"                     \
            -i "X-Complaints-To:"                       \
            -i "Injection-Date:"                        \
            -i "Injection-Info:"                        \
            -i "X-Injection-Date:"                      \
            -i "X-Injection-Info:"                      \

Paul Schleck <pschleck>
Sat 05 Feb 2022 03:04:38 AM UTC, comment #1: 

The bin/processApproved script runs a formail command which can use -I (delete) or -i (pre-pend with X-) arguments to transform the headers in the article before posting.  Adding the following lines to this command would implement the fix to this item:

            -i "NNTP-Posting-Date:"                     \
            -i "NNTP-Posting-Host:"                     \
            -i "X-Complaints-To:"                       \
            -i "Injection-Date:"                        \
            -i "Injection-Info:"                        \
            -i "X-Injection-Date:"                      \
            -i "X-Injection-Info:"                      \

Anonymous
Wed 02 Feb 2022 09:55:34 PM UTC, original submission:  

Articles posted from Google are turning up in moderation queues with the Injection-Date and Injection-Info headers already set. These headers should not be set by the posting agent, they should be added by the news server that receives the article after it has been approved by the moderator. Moderators must remove any Injection-Date, Injection-Info, or Xref headers that are already present. Properly configured news servers will reject articles that are submitted with these headers. See RFCs 5536 and 5537 for full details.

Discussing this with Tristan, we decided that the best course of action would be to rename existing headers to X-Original-Injection-Date and X-Original-Injection-Info before sending the article to the news server. This preserves the information in them, which may be useful for debugging or abuse reporting, while complying with the requirements of the RFC.

Rayner Lucas <rayner>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psychonaut (Posted a comment)
  • -email is unavailable- added by pschleck (Posted a comment)
  • -email is unavailable- added by rayner (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-06-23 rayner Planned ReleaseNone 2.6
    2022-10-06 rayner StatusConfirmed Ready For Test

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code