bugGNU Astronomy Utilities - Bugs: bug #61975, PSF scripts: keeping temporary...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #61975: PSF scripts: keeping temporary directory in radial profile calls

Submitter:  Raul Infante-Sainz <infantesainz>
Submitted:  Tue 01 Feb 2022 06:05:41 PM UTC
   
 
Category:  Installed scripts Severity:  3 - Normal
Item Group:  Crash Status:  Fixed
Privacy:  Public Assigned to:  infantesainz
Open/Closed:  Closed

Thu 10 Feb 2022 11:57:21 AM UTC, comment #1: 

Thanks a lot Raul! It has been merged to 'master' in Commit d7f080af7d2.

To avoid any future complications, how about setting the temporary directory for for each radial profile script to be a sub-directory of the temporary directory of the PSF script? This way, we don't have to worry about potentially conflicting file names, and the temporary directory can also be cleaner to check when debugging ;-).

Mohammad Akhlaghi <makhlaghi>
Group administrator
Tue 01 Feb 2022 06:05:41 PM UTC, original submission:  

There was a problem in two PSF scripts. In both scripts the problem was the same and it has been fixed (and ready to be merged): https://gitlab.com/infantesainz/gnuastro/-/commit/7c6f8151

More details in the commit message:

Until this commit, when constructing the PSF, the temporary directory was removed as soon as the radial-profile script finished. This is simply because the temporary directory for the PSF scripts and the  temporary directory for the radial profile script was the same. This is not good since the directory is removed in the middle of the execution.  Step by step, what happened was:
   
 - PSF scripts generated a temporary directory (tmpdir).
 - At some point, the PSF scripts called the radial profile script.
 - The radial profile script removed the temporary directory (tmpdir).
 - PSF scripts crashed as a consequence of the directory removal.
   
With this commit, this bug has been corrected by keeping the temporary files when calling the radial profile script (within the PSF scripts). By doing this, the temporary directory is kept until the end of the execution of the PSf script and the scripts don't crash.

Raul Infante-Sainz <infantesainz>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by makhlaghi (Posted a comment)
  • -email is unavailable- added by infantesainz (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-02-10 makhlaghi Assigned toNone infantesainz
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code