bugGNU Health - Bugs: bug #61923, Some qr string problem.

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #61923: Some qr string problem.

Submitter:  Feng Shu <tumashu>
Submitted:  Tue 25 Jan 2022 10:58:15 PM UTC
   
 
Category:  Functionality Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  meanmicio
Open/Closed:  Closed Release:  3.9.0
Module:  health_qrcode Component:  None

Jump to the original submission

Fri 28 Jan 2022 09:37:56 AM UTC, comment #7: 


comment #6:

>
> comment #5:
> > Of course, the focus needs to be on the generic search field (Shift+CTRL+F).
>
> Wow, I do not know it has shortcut :-), Maybe it should appear in HELP/Keybord Shortcuts.


Yes! I want to release a sample HELP document, so we, as a community, can work on the rest.

>
> >
> > It might be a good idea to put the focus directly on the search field when on the tree view!
>
> Set QR reader append a "Ctrl-F" or let QR string include "Ctrl-F" :-)
>


Embedding the control code is a good idea, but it might be a problem for other programs outside GNU Health that read the patient card or similar.

I like the concept of putting the focus on the tree view search. That would be for the next release though, since we're at code freeze period now :)

Bests

>
> >
> > Best
> >
> >
> >

Luis Falcon <meanmicio>
Group administrator
Fri 28 Jan 2022 02:01:29 AM UTC, comment #6: 


comment #5:

> Of course, the focus needs to be on the generic search field (Shift+CTRL+F).


Wow, I do not know it has shortcut :-), Maybe it should appear in HELP/Keybord Shortcuts.

>
> It might be a good idea to put the focus directly on the search field when on the tree view!


Set QR reader append a "Ctrl-F" or let QR string include "Ctrl-F" :-)


>
> Best
>
>
>

Feng Shu <tumashu>
Thu 27 Jan 2022 11:58:25 AM UTC, comment #5: 

Of course, the focus needs to be on the generic search field (Shift+CTRL+F).

It might be a good idea to put the focus directly on the search field when on the tree view!

Best



Luis Falcon <meanmicio>
Group administrator
Wed 26 Jan 2022 09:45:41 PM UTC, comment #4: 


> will go directly on the search field


really? no need to user manual select search field by click? i have no qr reader, so can not test this:)

Feng Shu <tumashu>
Wed 26 Jan 2022 05:05:57 PM UTC, comment #3: 

At the moment of reading from the QR reader, it detects a CR / newline, it will search for the ID (first line)

Patient model search looks for different fields (ID, alternative ID, federation accounts,...).

Bests
Luis


Luis Falcon <meanmicio>
Group administrator
Wed 26 Jan 2022 01:51:27 PM UTC, comment #2: 

when qr string insert into search widget, what will happen,
search just puid or puid + name: + age:..
if latter, i think we have problem for no English user.
for name: will be translated.

Feng Shu <tumashu>
Wed 26 Jan 2022 12:35:45 PM UTC, comment #1: 

Thanks Tumashu for the feedback!

I've cleanup the code, using how the f-string.

I have also removed the label in the QR codes, so the very first line in the different contexts is just the ID, making it easier to process.

Fixed at: https://hg.savannah.gnu.org/hgweb/health/rev/352f4cb87936

Normally, the person in admission has the barcode/qr reader. It scans the patient card and will go directly on the search field, retrieving the person, appointment, etc..

PS:The Lab tests CODE39 is a bit different, since it produces a barcode with a specific format to be processed by analyzers.

Please test and get back to us :)

Best
Luis

Luis Falcon <meanmicio>
Group administrator
Tue 25 Jan 2022 10:58:15 PM UTC, original submission:  

I think we should not hard code "," to Name.

>          qr_string = 'ID: ' + patient_id \
>            + '\nName: ' + patient_lastname + ',' \
>            + self.name.name \
>            + '\nPUID: ' + patient_puid \
>            + '\nGender: ' + patient_gender \
>            + '\nDoB: ' + str(patient_dob) \
>            + '\nBlood Type: ' + patient_blood_type \
>            + ' ' + patient_rh



By the way, In most case, how to use the qr_string when we get it from a scanners?
just use it as query string in gnuhealth-client search widget? if so, I think patient_puid
is enough, and we need not other info.

Feng Shu <tumashu>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by meanmicio (Posted a comment)
  • -email is unavailable- added by tumashu (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-03-05 meanmicio StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2022-01-26 meanmicio StatusNeed Info Ready For Test
    2022-01-26 meanmicio StatusNone Need Info
        Assigned toNone meanmicio
        ReleaseNone 3.9.0

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code