bugGNU gettext - Bugs: bug #61369, libxml/xmlIO.c: 2 * duplicated if...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #61369: libxml/xmlIO.c: 2 * duplicated if condition

Submitter:  David Binderman <dcb314>
Submitted:  Fri 22 Oct 2021 04:15:20 PM UTC
   
 
Category:  Build Severity:  2 - Minor
Item Group:  None Status:  Wont Fix
Privacy:  Public Assigned to:  haible
Open/Closed:  Closed

Mon 13 Feb 2023 11:01:45 PM UTC, comment #3: 

This issue needs to be fixed upstream, if at all.

For me the issue is very minor because
- the warning option -Wduplicated-cond is rarely used,
- the cascaded 'if' logic already does the right thing despite the warning.

If the reporter wants to help by reporting it upstream, OK. So far, this has not happened.

Bruno Haible <haible>
Group administrator
Sat 25 Jun 2022 07:00:05 PM UTC, comment #2: 

David Binderman,
Have you reported the issue upstream, at https://gitlab.gnome.org/GNOME/libxml2/-/issues ? It is not yet fixed upstream.

Bruno Haible <haible>
Group administrator
Tue 07 Dec 2021 04:52:09 PM UTC, comment #1: 

This issue is still present upstream, in the official libxml2.
Please, can you report the bug there, i.e. at http://xmlsoft.org/bugs.html ?
At some point, I will upgrade from upstream.

Bruno Haible <haible>
Group administrator
Fri 22 Oct 2021 04:15:20 PM UTC, original submission:  


gcc compiler with flag -Wduplicated-cond says:

libxml/xmlIO.c: In function ‘__xmlIOErr’:
libxml/xmlIO.c:389:24: warning: duplicated ‘if’ condition [-Wduplicated-cond]
  389 |         else if (errno == ETIMEDOUT) code = XML_IO_ETIMEDOUT;
      |                        ^
libxml/xmlIO.c:374:24: note: previously used here
  374 |         else if (errno == ETIMEDOUT) code = XML_IO_ETIMEDOUT;
      |                        ^
libxml/xmlIO.c:398:24: warning: duplicated ‘if’ condition [-Wduplicated-cond]
  398 |         else if (errno == EINPROGRESS) code = XML_IO_EINPROGRESS;
      |                        ^
libxml/xmlIO.c:290:24: note: previously used here
  290 |         else if (errno == EINPROGRESS) code = XML_IO_EINPROGRESS;
      |                        ^

David Binderman <dcb314>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by haible (Updated the item)
  • -email is unavailable- added by dcb314 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-02-13 haible StatusPostponed Wont Fix
        Assigned toNone haible
        Open/ClosedOpen Closed
    2022-06-25 haible Severity3 - Normal 2 - Minor
    2021-12-07 haible StatusNone Postponed
    2021-12-07 haible CategoryNone Build

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code