bugGNU Astronomy Utilities - Bugs: bug #61287, Two switch blocks miss...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #61287: Two switch blocks miss "break" in their branches

Submitter:  Vladimir Markelov <vvm>
Submitted:  Tue 05 Oct 2021 02:17:09 AM UTC
   
 
Category:  MakeCatalog Severity:  3 - Normal
Item Group:  Source code Status:  Fixed
Privacy:  Public Assigned to:  vvm
Open/Closed:  Closed

Tue 05 Oct 2021 07:52:35 AM UTC, comment #1: 

Thanks a lot for catching this very well-hidden bug! It has been implemented as Commit f7ea010ed5 (in your name: I didn't add anything extra except the description of the bug in the 'NEWS' file).

Mohammad Akhlaghi <makhlaghi>
Group administrator
Tue 05 Oct 2021 02:17:09 AM UTC, original submission:  

It seems makecatalog's columns.c misses "break" in a couple of places. I do not think fallthrough there is intended:

makecatalog/columns.c


2825          case UI_KEY_GEOZ:
2826            ((float *)colarr)[cind] = MKC_RATIO( ci[CCOL_GZ],
2827                                                 ci[CCOL_NUMALL] );
2828 // I think "break" should be here
2829          case UI_KEY_MINVX:
2830            ((float *)colarr)[cind] = MKC_RATIO( ci[CCOL_MINVX], ci[CCOL_MINVNUM] );
2831            break;


and this one


2443        case UI_KEY_CLUMPSGEOZ:
2444          ((float *)colarr)[oind] = MKC_RATIO( oi[OCOL_C_GZ],
2445                                               oi[OCOL_C_NUMALL] );
2446 // I think "break" should be here
2447        case UI_KEY_MINVX:
2448          ((float *)colarr)[oind] = MKC_RATIO( oi[OCOL_MINVX], oi[OCOL_MINVNUM] );
2449          break;

-verbatim

Vladimir Markelov <vvm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by makhlaghi (Posted a comment)
  • -email is unavailable- added by vvm (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-10-05 makhlaghi StatusNone Fixed
        Assigned toNone vvm
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code