bugGNU Astronomy Utilities - Bugs: bug #60999, No checks on content when...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #60999: No checks on content when plain-text table doesn't have metadata

Submitter:  Mohammad Akhlaghi <makhlaghi>
Submitted:  Sun 01 Aug 2021 06:46:18 PM UTC
   
 
Category:  Libraries Severity:  3 - Normal
Item Group:  Output not reasonable Status:  Fixed
Privacy:  Public Assigned to:  makhlaghi
Open/Closed:  Closed

Sun 01 Aug 2021 07:04:10 PM UTC, comment #1: 

This bug has been fixed in Commit b4628d7265.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Sun 01 Aug 2021 06:46:18 PM UTC, original submission:  

When the user gives a plain-text file with no metadata, the 'txt.h' library just counts the tokens in the top line (to find number of columns in whole table) and assumes the contents are double precision floating point.

It ignores lines that are commented (starting with a '#'), however, when the first non-commented line isn't actually a number, this will cause very confusing error messages later in the calling programs: since the number of tokens in each non-commented line (usually English lines that aren't commented) can be different (and usually also different from the number of columns in the table).

The plain-text table reading library should check if the non-commented lines are actually a number and abort with a warning if its not a number, printing the problematic token, so the users notices the cause of the problem and corrects their input.

Mohammad Akhlaghi <makhlaghi>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by makhlaghi (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-08-01 makhlaghi StatusIn Progress Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code