bugSTUMP - Bugs: bug #60445, Rejection message should be...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #60445: Rejection message should be printed before the rejected article

Submitted by:  Tristan Miller <psychonaut>
Submitted on:  Fri 23 Apr 2021 06:53:51 AM UTC
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  owenrees
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Wed 08 Dec 2021 11:11:47 AM UTC, comment #5: 

Fix has been merged to master.

Owen Rees <owenrees>
Project Member
Tue 23 Nov 2021 10:52:48 PM UTC, comment #4: 

I decided to go ahead with pushing the change anyway - fix-messages branch - which includes the fix-pgpmoose changes because I wanted to be sure that signed approvals were not affected by the change.

Owen Rees <owenrees>
Project Member
Mon 22 Nov 2021 10:57:30 PM UTC, comment #3: 

I have a possible (one line) change to STUMP that would just fold long lines coming in as the comment added by a moderator. This might be good enough but if the comment is really a paragraph with lines that are slightly too long, the effect will be a rather ugly long, short,long,short sequence. There is a Text::Wrap module that should do a better job if adding a dependency on it is considered sensible.

For historical reasons, I would choose 72 as the column at which to wrap and that is what I have been experimenting with.

I will wait for opinions on which way to go and if the divider lines should be changed before pushing anything.

Owen Rees <owenrees>
Project Member
Sat 20 Nov 2021 04:09:38 PM UTC, comment #2: 

Re previous comment - I was thinking this was a Webstump issue - and part of the solution is better done there so it is just the divider lines and spurious spaces that seem to be the problem for STUMP.

Owen Rees <owenrees>
Project Member
Sat 20 Nov 2021 04:05:27 PM UTC, comment #1: 

I have been testing rejection messages and the behaviour I observe is not as described. An example is (file #52304). First is the PGP signed message marker. Next is a long comment added using the text input line on the single post moderation page. After that is the contents of the rejection message file etc.dist/messages/offtopic. Next is the separator line. Then the rejected message with each line prefixed by '> '. Finally the PGP signature (using a key that exists only on my test system but which Thunderbird reports as a valid signature of the message).

The order of the items seems reasonable to me.

The line from the input box could be folded in some appropriate way. It might be better to use a textarea in the input form rather than a text input box as that would make it easier to enter a reasonable length message. I will experiment with that to see what can be done.

The rejection message file is copied directly so the message will have whatever newlines are in the file.

I am not so sure about putting a blank line after the divider line. It would not be obvious whether the blank line is part of the message or part of the divider, especially if the '> ' prefixes were removed. I do not think that there is any need for them and they are easy to confuse with quoted lines in the message. Personally, I would use a divider line more like this:
====== Full text of your message follows ======
Using the same punctuation at both ends of the line is more conventional (as in the PGP signature lines).

Note that if a moderator adds a comment to an approved message that is added at the end after the body of the message both in the email and the posted message. The divider line has a trailing space and if the posted message has format=flowed that will cause the comment to appear on the same line as the divider if the display is wide enough.

I will experiment with using a textarea instead of a single line input and folding its content in a suitable way. Fixing the divider lines and the spurious spaces will need changes to STUMP rather than Webstump so an issue will be needed there as well.

Owen Rees <owenrees>
Project Member
Fri 23 Apr 2021 06:53:51 AM UTC, original submission:  

When an article is rejected, STUMP sends a rejection e-mail that reproduces the rejected article along with a message explaining a reason for the rejection.  There are two problems with the way this rejection is currently formatted:

1) The rejection message is printed at the end of the reproduced article, which makes it easy to miss.

2) The rejection message doesn't contain any newlines.  It's even missing a newline between the divider ("===========================================================") and the start of the message.

So we should change the code so that (a) the rejection message is printed before the reproduced submission, and (b) the rejection message is properly formatted (with no line exceeding 75 characters, and with newlines around the line that divides the rejection message from the submission).

Tristan Miller <psychonaut>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #52304:  rejection.txt added by owenrees (2KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by owenrees (Updated the item)
  • -email is unavailable- added by psychonaut (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-12-08 owenrees StatusConfirmed => Fixed
        Open/ClosedOpen => Closed
    2021-11-20 owenrees Assigned toNone => owenrees
    2021-11-20 owenrees Attached File- => Added rejection.txt, #52304

    Back to the top


    Powered by Savane 3.9