bugGNU libunistring - Bugs: bug #59491, The _imp_ symbol for x64

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #59491: The _imp_ symbol for x64

Submitter:  kenjiuno <kenjiuno>
Submitted:  Fri 20 Nov 2020 11:30:24 AM UTC
   
 
Category:  Build Severity:  3 - Normal
Item Group:  None Status:  Fix Released
Privacy:  Public Assigned to:  haible
Open/Closed:  Closed

Sat 21 Nov 2020 11:34:37 PM UTC, comment #1: 

Thanks for the report. Fixed through https://git.savannah.gnu.org/gitweb/?p=libunistring.git;a=commitdiff;h=31600a8bd3ad1e27715e214227b6b64196aff631

> I don't know if LP64 is good selection, or not.

It gets in the right direction. But MSVC does not define _LP64_ or _LP64; it defines _WIN64 instead.

> # define IMP(x) imp##x

An extra underscore is needed before '_imp', because at the linker level these symbols all start with '__imp_'. (Use, for example, "nm foo.dll.lib" to see it.)

Bruno Haible <haible>
Group administrator
Fri 20 Nov 2020 11:30:24 AM UTC, original submission:  

In woe32dll/export.h


/* IMP(x) is a symbol that contains the address of x.  */
# define IMP(x) _imp__##x


I think that 64 bit version (x86_64-w64-mingw32 for example) needs to cut leading one underscore.


 /* IMP(x) is a symbol that contains the address of x.  */
#if __LP64__
# define IMP(x) _imp_##x
#else
# define IMP(x) _imp__##x
#endif


I don't know if _LP64_ is good selection, or not.

kenjiuno <kenjiuno>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by haible (Posted a comment)
  • -email is unavailable- added by kenjiuno (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-01-04 haible StatusFixed Fix Released
    2020-11-21 haible StatusNone Fixed
        Assigned toNone haible
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code