GNU gettext - Bugs: bug #57406, mbsinit.c fails to compile with...
You are not allowed to post comments on this tracker with your current authentication level.
bug #57406: mbsinit.c fails to compile with GCC 9.2.0 on MinGW-w64 (i686)
Submitter: | Tom Kacvinsky <tomkacvinsky> | ||
Submitted: | Fri 13 Dec 2019 03:32:45 PM UTC | ||
Category: | Build | Severity: | 3 - Normal |
Item Group: | None | Status: | Fix Released |
Privacy: | Public | Assigned to: | haible |
Open/Closed: | Closed |
Jump to the original submission
Tue 17 Dec 2019 01:30:21 PM UTC, comment #6: |
Martin Storsjö <mstorsjo> |
Tue 17 Dec 2019 10:10:14 AM UTC, comment #5: Hi Martin,
|
Bruno Haible <haible> |
Mon 16 Dec 2019 09:44:50 PM UTC, comment #4: I'm continuing this discussion here, even though this matter is entirely between gnulib and mingw-w64 now, not related to gettext itself.
|
Martin Storsjö <mstorsjo> |
Mon 16 Dec 2019 05:33:34 PM UTC, comment #3:
|
Bruno Haible <haible> |
Mon 16 Dec 2019 03:02:18 PM UTC, comment #2: WE have been having discussions on the list and it turns out the trick that was proposed won't work. mbsinit() is not auto-detected by the gettext configure command, but is hardcoded into the mbsinit.c file (gettext-runtime/gnulib-lib/mbsinit.)::
|
Tom Kacvinsky <tomkacvinsky> |
Sat 14 Dec 2019 01:20:41 AM UTC, comment #1: I see recent relevant patches here:
|
Bruno Haible <haible> |
Fri 13 Dec 2019 03:32:45 PM UTC, original submission:
I see this error
|
Tom Kacvinsky <tomkacvinsky> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2023-01-04 | haible | Status | Fixed | Fix Released | |
2019-12-17 | haible | Status | Need Info | Fixed | |
Assigned to | None | haible | |||
Open/Closed | Open | Closed | |||
2019-12-14 | haible | Status | None | Need Info |
Powered by Savane 3.13-758e.
Corresponding source code
Hi Bruno,
comment #5:
Awesome, thanks! The fix for this matter seems to work fine for me.
I'm running into some other build issues in the gltests subdirectory though, in my clang/libc++/ucrt setup, but I'll investigate that closer so I understand the root cause before making any more noise about it, and I'll file that issue directly with gnulib when I understand it.
The UCRT support is tricky as it effectively alters the ABI for most things that interacts with the crt, so it's hard to gradually enable it in an existing setup, it's possible to use it primarily when building a new sysroot from scratch and only building things from source.
That sounds good! I tested the mbsinit/ucrt change in mingw-w64 with the test package you provided, and it seems to work fine, so I'll hold off of it for now, but try to get it integrated a bit later, when more packages have picked up newer gnulib versions.