bugGNU Astronomy Utilities - Bugs: bug #55740, Diamond like shapes in nearst-ngb...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #55740: Diamond like shapes in nearst-ngb interpolation affecting NoiseChisel

Submitter:  Mohammad Akhlaghi <makhlaghi>
Submitted:  Tue 19 Feb 2019 08:38:41 PM UTC
   
 
Category:  NoiseChisel Severity:  4 - Important
Item Group:  Output not reasonable Status:  Fixed
Privacy:  Public Assigned to:  makhlaghi
Open/Closed:  Closed

Wed 20 Feb 2019 06:28:56 PM UTC, comment #2: 

An image is being attached for a demonstration of this bug.


Mohammad Akhlaghi <makhlaghi>
Group administrator
Tue 19 Feb 2019 08:51:41 PM UTC, comment #1: 

This bug has been fixed and pushed to the main repo!

It was a very bad bug, causing bad results in NoiseChisel in many situations! I will make a beta-release soon.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Tue 19 Feb 2019 08:38:41 PM UTC, original submission:  

In the `gal_interpolate_close_neighbors', we weren't re-initializing the flags of the interpolated neighbors prior to interpolation. As a result, after finding the median operator for the first time on each thread, no other value was sorted any more (the median finding function would assume its sorted).

This directly affected NoiseChisel in a very bad way: On the tiles where outlier values fell right in the middle of the list of good neighbor values, the outlier would be reported as the median (because the median is the middle value!).

In practice, this caused diamond like structures around outlier tiles during NoiseChisel's threshold finding and Sky estimation steps.

This bug came up during a discussion with Roberto Baena Gallé.

Mohammad Akhlaghi <makhlaghi>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #46317:  bug-55740.jpg added by makhlaghi (281KiB - image/jpeg)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by makhlaghi (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-02-20 makhlaghi Attached File- Added bug-55740.jpg, #46317
    2019-02-19 makhlaghi StatusIn Progress Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code