bugGNU gettext - Bugs: bug #55356, libcroco fails to build when gcc's...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #55356: libcroco fails to build when gcc's format-security error is enabled

Submitter:  Frank Hunleth <fhunleth>
Submitted:  Tue 01 Jan 2019 08:56:31 PM UTC
 
Category:  Build Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  haible
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Tue 14 Apr 2020 12:18:03 PM UTC, comment #2: 

The fix is contained in gettext 0.20.2.

Bruno Haible <haible>
Project Administrator
Sat 17 Aug 2019 07:29:26 PM UTC, comment #1: 

Thanks for the report. This is fixed by upgrading to the latest libcroco release, through
https://git.savannah.gnu.org/gitweb/?p=gettext.git;a=commit;h=859f2fd8920fb5a48226eac8af8458c871b7f392

Bruno Haible <haible>
Project Administrator
Tue 01 Jan 2019 08:56:31 PM UTC, original submission:  

libcroco has several instances of using fprintf to print out arbitrary strings using the second parameter. This causes the following compiler error when -Werror=format-security is enabled:

libcroco/cr-statement.c:2610:17: error: format not a string literal and no format arguments [-Werror=format-security]
                 fprintf (a_fp, str);
                 ^~~~~~~
libcroco/cr-statement.c: In function 'cr_statement_dump_charset':

It looks like this was fixed upstream in the following commit: https://github.com/GNOME/libcroco/commit/c7197cad42d6269739f379025c2bec9e474c8027.

Would it be possible to either pull this commit or resync to the latest upstream libcroco?

Frank Hunleth <fhunleth>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by haible (Updated the item)
  • -email is unavailable- added by fhunleth (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-08-17 haible StatusNone Fixed
        Assigned toNone haible
        Open/ClosedOpen Closed
    2019-01-02 haible CategoryNone Build

    Back to the top


    Powered by Savane 3.9