mainAutoconf - Support: sr #110307, Upstream:...

 
 

sr #110307: Upstream: netbsd/patch-lib_autoconf_fortran.m4

Submitter:  Remi Attab <rattab>
Submitted:  Mon 07 Sep 2020 06:34:38 PM UTC
   
 
Priority:  * 2 - Eventually Severity:  2 - Minor
Status:  Need Info Privacy:  Public
Assigned to:  None Open/Closed:  Open
Operating System:  *BSD
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 08 Dec 2023 01:53:46 PM UTC, comment #1: 

The patch needs to be reviewed and probably rewritten by someone familiar with the landscape of Fortran compilers.  It is unclear why NetBSD made this change in the first place, so contacts within that community who can help track that down are also desired.

 Zack Weinberg <zackw>
Group administrator
Mon 07 Sep 2020 06:34:38 PM UTC, original submission:  

`Rpath is a linker option, so prefix it with -Wl. Bump revision.`
https://github.com/NetBSD/pkgsrc/commit/e2df8e9fa93385eadb629104462ef270d670b249

Patch can be merged as is but needs to be validated for correctness.

Comments from Zack W.

> The macro being changed is quite hairy and I think this is higher-risk than it looks. -Wl, is a GCC feature (also supported by LLVM). It may be necessary to do something cleverer here to make sure this still works with other Fortran compilers.  Please file a bug for this one.  If you can dig up discussion of why the change was made on the NetBSD mailing lists, commit history, etc. that would be really helpful.


Wasn't able to find any mailing list threads related to this although I may just be bad at tracking down information in mailing lists. Otherwise, will try reaching out to the author and see if he can provide additional context.

Upstream patch triage project: https://git.sr.ht/~rattab/autoconf-upstream

 Remi Attab <rattab>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #49760:  patch-lib_autoconf_fortran.m4 added by rattab (498B - application/x-m4)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by zackw (Updated the item)
  • -email is unavailable- added by rattab (Submitted the item)
  • -email is unavailable- added by rattab

    •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-12-08 zackw StatusNone Need Info
    2023-12-08 zackw Priority1 - Blocked 2 - Eventually
    2020-09-24 zackw Priority5 - Unprioritized 1 - Blocked
    2020-09-07 rattab Attached File- Added patch-lib_autoconf_fortran.m4, #49760
        Carbon-Copy- Added zackw

    Back to the top

    Copyright © 2024 Free Software Foundation, Inc.
    Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
    The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
    Page source code

    Powered by Savane 3.13-d453.
    Corresponding source code