mainAutoconf - Support: sr #110215, AC_EGREP_HEADER appears to be...

 
 

sr #110215: AC_EGREP_HEADER appears to be broken in master

Submitter:  Ross Burton <rossburton>
Submitted:  Mon 23 Mar 2020 09:58:06 PM UTC
   
 
Priority:  * 5 - Unprioritized Severity:  3 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Operating System:  GNU/Linux
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 12 Jul 2020 03:28:12 PM UTC, comment #4: 

AC_PROG_EGREP added to the replacement for AC_HEADER_STDC in d5cb54d02dba7ba9c0cd3736b46e7b50a71ce2f3.

Zack Weinberg <zackw>
Group administrator
Fri 10 Jul 2020 05:43:50 PM UTC, comment #3: 

Never mind, I found the discussion on bug-autoconf.  This is arguably a regression from 2.69.  Copying over the relevant bits of that discussion:

Nick Bowler:

> ... the long-obsolete AC_HEADER_STDC, previously used internally by
> AC_INCLUDES_DEFAULT, used AC_EGREP_HEADER.  The AC_HEADER_STDC macro
> is now a no-op (and is not used at all within Autoconf anymore), so
> that change is likely what made the first use of AC_EGREP_HEADER the
> one inside the if condition, causing the observed results.


Eric Blake:

> We already have autoupdate remove a call to AC_HEADER_STDC and
> replace it with the direct side-effect results of setting
> STDC_HEADERS and TIME_WITH_SYS_TIME; should we also tweak that to
> preserve the side-effect of AC_REQUIRES([AC_EGREP_HEADER)], to
> minimize the pain on external projects unaware that they were
> depending on that side-effect? Or maybe just tweak the NEWS blurb to
> mention that users depending on $GREP being set early may need to be
> careful?


Having autoupdate insert AC_REQUIRE([AC_PROG_EGREP]) for AC_HEADER_STDC,
and mentioning this issue in NEWS, both seem like good ideas to me.


Zack Weinberg <zackw>
Group administrator
Fri 10 Jul 2020 04:21:38 PM UTC, comment #2: 

Before I close this, could you please explain in a little more detail what the "user error" actually was?

Zack Weinberg <zackw>
Group administrator
Tue 24 Mar 2020 07:18:14 PM UTC, comment #1: 

This can be closed: user error.

Ross Burton <rossburton>
Mon 23 Mar 2020 09:58:06 PM UTC, original submission:  

apt 1.2.31 builds fine with autoconf 2.69.  With git master:

| checking for h_errno... configure: error: "not found."

That code is:

dnl HP-UX needs -d_XOPEN_SOURCE_EXTENDED for h_errno
AC_MSG_CHECKING(for h_errno)
AC_EGREP_HEADER(h_errno, netdb.h, [AC_MSG_RESULT(normal)],
   [CPPFLAGS="$CPPFLAGS -D_XOPEN_SOURCE_EXTENDED"
    AC_EGREP_HEADER(h_errno, netdb.h,
       [AC_MSG_RESULT(needs _XOPEN_SOURCE_EXTENDED)],
       [AC_MSG_ERROR("not found.")])
   ])

Obviously this is horrible, but it's out there.

Ross Burton <rossburton>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by zackw (Posted a comment)
  • -email is unavailable- added by rossburton (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-07-12 zackw StatusConfirmed Done
        Open/ClosedOpen Closed
    2020-07-10 zackw StatusNeed Info Confirmed
    2020-07-10 zackw StatusNone Need Info

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code