mainGNU gettext - Support: sr #108864, gettext-0.19.5.1 compiling problem

 
 

sr #108864: gettext-0.19.5.1 compiling problem

Submitter:  <pan7>
Submitted:  Wed 12 Aug 2015 06:58:32 AM UTC
   
 
Category:  None Priority:  5 - Normal
Severity:  3 - Normal Status:  Done
Privacy:  Public Assigned to:  ueno
Open/Closed:  Closed Operating System:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 21 Aug 2015 07:50:57 AM UTC, comment #3: 

Pushed a fix as:
http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=2929cd21

I will post it to libc-alpha later, with pending patches.

Daiki Ueno <ueno>
Group administrator
Mon 17 Aug 2015 09:06:44 AM UTC, comment #2: 

Removing the semicolon in file loadmsgcat.c line 788:
  __libc_lock_define_initialized_recursive (static, lock)
is fixing it for me.

<pan7>
Sat 15 Aug 2015 10:08:13 AM UTC, comment #1: 

Couldn't it also be fixed by removing the last semicolon of:

  __libc_lock_define_initialized_recursive (static, lock);

?

It is possible that the extra semicolon expands to an empty statement, which pre-C99 compilers complain of.

> When i move this line to the bottom of the definitions it compiles.


Yes, this sounds like the right fix, which wouldn't break consistency with the Glibc style.

For reference, here is the original commit introduced this change:
http://git.savannah.gnu.org/cgit/gettext.git/commit/?id=b0ca3de6

Daiki Ueno <ueno>
Group administrator
Wed 12 Aug 2015 06:58:32 AM UTC, original submission:  

gettext-runtime\intl\loadmsgcat.c(789): error C2143: syntax error : missing ';' before 'type'

When i move this line to the bottom of the definitions it compiles.
  __libc_lock_define_initialized_recursive (static, lock);

It can't initialize the static variable?

<pan7>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by haible (Updated the item)
  • -email is unavailable- added by ueno (Posted a comment)
  • -email is unavailable- added by ueno
  • -email is unavailable- added by pan7 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-09-10 haible Assigned toNone ueno
    2015-08-21 ueno StatusNone Done
        Open/ClosedOpen Closed
    2015-08-15 ueno Carbon-Copy- Added siddhesh poyarekar <siddhesh@redhat.com>

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code