patchGNU Octave - Patches: patch #10218, interpreter: Avoid string...

 
 

patch #10218: interpreter: Avoid string construction 3

Submitter:  John W. Eaton <jwe>
Submitted:  Wed 22 Jun 2022 01:42:48 PM UTC
   
 
Category:  Core : other Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 28 Feb 2023 02:47:58 PM UTC, comment #2: 

I see now that this patch is also the file avoidstringctors_3.patch attached to patch #10147.  There, I added the comment

I agree that setting retval = "" (the first part of the diff) is unnecessary, but setting dir_name = "" in the other two bits of the diff ensures that dir_name is empty if no valid function is found.  That seems reasonable to me, as the user of the function might have passed something else and setting it to "" could avoid later confusion.  I understand these are "internal" functions and that maybe fcn_info "is not supposed to be used that way" but I tend to worry about future maintenance.

I pushed this change:

http://hg.savannah.gnu.org/hgweb/octave/rev/359de694adce

Closing report.

John W. Eaton <jwe>
Group administrator
Tue 28 Feb 2023 11:32:34 AM UTC, comment #1: 

Updated patch attached. This needs patches new_30599 onwards to be applied in sequence first.

(file #54403)

Arun Giridhar <arungiridhar>
Group Member
Wed 22 Jun 2022 01:42:48 PM UTC, original submission:  

From Petter Tomner <petter>, extracted from the zip file attached to the following comment in the discourse thread "WIP stack VM f\
or Octave": https://octave.discourse.group/t/wip-stack-vm-for-octave/2884/10

Remove unnecessary ""-writes

John W. Eaton <jwe>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #54403:  new_30600.patch added by arungiridhar (704B - text/x-patch)
file #53336:  octave_30600.patch added by jwe (1018B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by arungiridhar (Updated the item)
  • -email is unavailable- added by jwe (Submitted the item)
  • -email is unavailable- added by jwe
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-02-28 jwe StatusNone Done
        Open/ClosedOpen Closed
    2023-02-28 arungiridhar Attached File- Added new_30600.patch, #54403
    2022-06-22 jwe Attached File- Added octave_30600.patch, #53336
        Carbon-Copy- Added petter

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code