patchGNU Octave - Patches: patch #9551, sinint/cosint from GSoC 2017

 
 

patch #9551: sinint/cosint from GSoC 2017

Submitter:  Colin Macdonald <cbm>
Submitted:  Wed 24 Jan 2018 08:08:01 AM UTC
   
 
Category:  Core : new feature Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 07 Apr 2018 12:23:23 AM UTC, comment #3: 

I believe the patches and problems discussed here have already been merged to Octave stable, closing as done. Please comment or reopen if I got that wrong.

Mike Miller <mtmiller>
Group Member
Sat 27 Jan 2018 10:50:46 AM UTC, comment #2: 

Hi,

I tried comparing both scripts for small imag values and it turns out that both scripts output don't show any mismatch.
The script that I used is https://paste.ubuntu.com/26469585/

I tried finding some resource to compare the error in values as compared to the expected result but unfortunately, I couldn't find one.I would be grateful if you can provide me one to deepen my understanding.

Any criticism and/or suggestions are most welcome :)

Thanks

Anushi Maheshwari <anushi>
Thu 25 Jan 2018 07:51:06 PM UTC, comment #1: 

Hi Colin,
In file #43084 there is a patch that solves the problem with pure real negative values. I'm not sure it solves also the problem with imag<=1e-15 but I hope so. Could you test the patch with the problematic values you already found?

Michele Ginesi <m_ginesi>
Wed 24 Jan 2018 08:08:01 AM UTC, original submission:  

I'm reviewing Michele's very nice work from last summer.

Here I'm looking at cosint and sinint.

I've attached Michele's patch and then my patches on top of it.

Unfortunately, I found a bug in cosint for pure real points along the negative real line, where the error grows very large.  Also occurs when the imag component is smaller than 1e-15 (note this value in the code).  I haven't tried to fix this yet.

Since this isn't quite ready to merge :( should I fork  onhttps://bitbucket.org/M_Ginesi/octave?  Send merge request?


Colin Macdonald <cbm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #43084:  patch_cosint.patch added by m_ginesi (1KiB - text/x-patch - Hi Colin,)
file #43060:  sinint_cosint_004.patch added by cbm (4KiB - text/x-patch)
file #43061:  sinint_cosint_005.patch added by cbm (850B - text/x-patch)
file #43056:  sinint_cosint_000.patch added by cbm (13KiB - text/x-patch)
file #43057:  sinint_cosint_002.patch added by cbm (3KiB - text/x-patch)
file #43058:  sinint_cosint_001.patch added by cbm (4KiB - text/x-patch)
file #43059:  sinint_cosint_003.patch added by cbm (913B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by anushi (Posted a comment)
  • -email is unavailable- added by m_ginesi (Updated the item)
  • -email is unavailable- added by cbm (Submitted the item)
  • -email is unavailable- added by cbm
  • -email is unavailable- added by cbm
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 12 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-04-07 mtmiller StatusNone Done
        Open/ClosedOpen Closed
    2018-01-25 m_ginesi Attached File- Added patch_cosint.patch, #43084
    2018-01-24 cbm Attached File- Added cosint_bug_negative_real.png, #43062
    2018-01-24 cbm Attached File- Added sinint_cosint_004.patch, #43060
        Attached File- Added sinint_cosint_005.patch, #43061
    2018-01-24 cbm Attached File- Added sinint_cosint_000.patch, #43056
        Attached File- Added sinint_cosint_002.patch, #43057
        Attached File- Added sinint_cosint_001.patch, #43058
        Attached File- Added sinint_cosint_003.patch, #43059
        Carbon-Copy- Added -email is unavailable-
        Carbon-Copy- Added caliari

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code