patchGNUstep - Patches: patch #7557, patch for bug #33568 gnustep does...

Group
 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7557: patch for bug #33568 gnustep does not implement the -URLBy* methods introduced in Mac OS X 10.6

Submitter:  julian <julian_>
Submitted:  Fri 17 Jun 2011 08:34:11 AM UTC
   
 
Category:  Foundation Priority:  5 - Normal
Status:  Ready For Test Privacy:  Public
Assigned to:  CaS Open/Closed:  Closed

Sat 18 Jun 2011 01:19:05 PM UTC, comment #4: 

Ah ... I did implement these methods (among others) ... though I'm not sure my implementations are completely correct.

I think this patch looks OK for file URLS (should give the same result as the stuff I wrote), but not for other URLs (since it applies NSString path handling methods to the -relativeString values ... which aren't paths).

Anyway, what would be really good would be if someone could provide a load of testcases for all these methods ... demonstrating behavior with a variety of different file URLS and a variety of different non-file URLs.  We could then run the testsuite on OSX (to confirm the testcase correctness) and ensure that GNUstep matches OSX behavior.

Richard Frith-Macdonald <CaS>
Group Member
Sat 18 Jun 2011 12:44:25 PM UTC, comment #3: 

The NSString StringBy* method used would need to be replaced by a NSURL URLBy* method where they are used.
As far as I can see, it seems they plan to add the NSURL patches/methods to SOPE in a catagegory, and then check for the version of gnustep-base whether it is (already) available or not, and either use the category or the version from gnustep-base...



Sebastian Reitenbach <buzzdee>
Group Member
Sat 18 Jun 2011 12:36:16 PM UTC, comment #2: 

Thank you for this patch!

Looks like Richard already added a (completely reworked) version of this patch to base.
I am not entirely sure this will benefit the SOPE/SOGO developers as the underlying cod still calls into the NSString path handling code. But I may have missed some details here.


Fred Kiefer <FredKiefer>
Group Member
Fri 17 Jun 2011 09:02:22 AM UTC, comment #1: 

Hi,

adding this to the planned 1.22.1 of gnustep-base would be great and help SOPE/SGOo. They are using StringByDeletingLastPathComponent or the like from NSString, which, now it made more compatible with gnustep-base-1.22.1, breaks SOPE/SOGo. Instead of manually hand rolling complicated workaround, it would be way much easier, to use the URLByDeletingLastPathComponent.

Sebastian

Sebastian Reitenbach <buzzdee>
Group Member
Fri 17 Jun 2011 08:34:11 AM UTC, original submission:  


julian <julian_>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #23533:  NSURLHeaderPatch.diff added by julian_ (599B - application/octet-stream - and the header patch)
file #23532:  NSURLPatch.diff added by julian_ (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by CaS (Posted a comment)
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by buzzdee (Posted a comment)
  • -email is unavailable- added by julian_ (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-06-18 FredKiefer CategoryNone Foundation
        StatusNone Ready For Test
        Assigned toNone CaS
        Open/ClosedOpen Closed
    2011-06-17 julian_ Attached File- Added NSURLHeaderPatch.diff, #23533
    2011-06-17 julian_ Attached File- Added NSURLPatch.diff, #23532

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code