GNUstep - Patches: patch #7557, patch for bug #33568 gnustep does...
You are not allowed to post comments on this tracker with your current authentication level.
patch #7557: patch for bug #33568 gnustep does not implement the -URLBy* methods introduced in Mac OS X 10.6
Submitter: | julian <julian_> | ||
Submitted: | Fri 17 Jun 2011 08:34:11 AM UTC | ||
Category: | Foundation | Priority: | 5 - Normal |
Status: | Ready For Test | Privacy: | Public |
Assigned to: | CaS | Open/Closed: | Closed |
Sat 18 Jun 2011 01:19:05 PM UTC, comment #4: |
Richard Frith-Macdonald <CaS> |
Sat 18 Jun 2011 12:44:25 PM UTC, comment #3: The NSString StringBy* method used would need to be replaced by a NSURL URLBy* method where they are used.
|
Sebastian Reitenbach <buzzdee> |
Sat 18 Jun 2011 12:36:16 PM UTC, comment #2: Thank you for this patch!
|
Fred Kiefer <FredKiefer> |
Fri 17 Jun 2011 09:02:22 AM UTC, comment #1: Hi,
|
Sebastian Reitenbach <buzzdee> |
Fri 17 Jun 2011 08:34:11 AM UTC, original submission:
|
julian <julian_> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2011-06-18 | FredKiefer | Category | None | Foundation | |
Status | None | Ready For Test | |||
Assigned to | None | CaS | |||
Open/Closed | Open | Closed | |||
2011-06-17 | julian_ | Attached File | - | Added NSURLHeaderPatch.diff, #23533 | |
2011-06-17 | julian_ | Attached File | - | Added NSURLPatch.diff, #23532 |
Powered by Savane 3.13-758e.
Corresponding source code
Ah ... I did implement these methods (among others) ... though I'm not sure my implementations are completely correct.
I think this patch looks OK for file URLS (should give the same result as the stuff I wrote), but not for other URLs (since it applies NSString path handling methods to the -relativeString values ... which aren't paths).
Anyway, what would be really good would be if someone could provide a load of testcases for all these methods ... demonstrating behavior with a variety of different file URLS and a variety of different non-file URLs. We could then run the testsuite on OSX (to confirm the testcase correctness) and ensure that GNUstep matches OSX behavior.