patchGnash - The GNU Flash player - Patches: patch #4817, Latest change on styles.cpp broke...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4817: Latest change on styles.cpp broke gradient loading

Submitter:  Michael Carlson <corfe>
Submitted:  Sat 21 Jan 2006 01:45:41 PM UTC
   
 
Category:  None Priority:  7 - High
Status:  Ready For Test Privacy:  Public
Assigned to:  corfe Open/Closed:  Closed

Thu 26 Jan 2006 05:15:49 PM UTC, comment #1: 

This patch has been applied, and as far as I can tell, gradients load just fine again.

Rob Savoye <rsavoye>
Group administrator
Sat 21 Jan 2006 01:45:41 PM UTC, original submission:  

The latest change to styles.cpp a day or so ago broke loading gradients, when an assert was switched to an if (with a much clearer error message).

The original patch did something like this:

- assert(condition)
+ if (condition) reporterror(); abort();

When it should instead have done this:
- assert(condition)
+ if (!condition) reporterror(); abort();

This broke several flash files for me. The attached patch fixes the problem.

Michael Carlson <corfe>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #9460:  gradient added by corfe (625B - application/octet-stream - Fix gradient loading again)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-01-26 rsavoye Open/ClosedOpen Closed
2006-01-26 strk StatusNone Ready For Test
    Assigned toNone corfe
2006-01-21 corfe Attached File- Added gradient, #5794

Back to the top

Powered by Savane 3.13-d3ae.
Corresponding source code