patchPSPP - Patches: patch #9955, Replace Gimp with ImageMagick

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9955: Replace Gimp with ImageMagick

Submitter:  Michel Boaventura <michelboaventura>
Submitted:  Fri 17 Jul 2020 04:47:43 PM UTC
   
 
Category:  None Item Group:  None
Status:  Wont Do Assigned to:  None
Open/Closed:  Closed

Fri 17 Jul 2020 07:45:17 PM UTC, comment #3: 


comment #1:

> You are right that gimp is magnetudes slower than other tools, and in many respects is an overkill for this job.
>
> However, this was a deliberate decision since gimp (like pspp) is a GNU project and the policy is to use other GNU tools where feasible.


I think it would be reasonable to support more than one tool here.

Also, my guess is that most of the slowness of GIMP is a startup cost.  Maybe there is a way to convert more than one image in a single run, speeding things up significantly.

Finally, running "make -f Smake -j$(nproc)" also speeds things up.

Ben Pfaff <blp>
Group administrator
Fri 17 Jul 2020 06:31:53 PM UTC, comment #2: 

Hum, I didn't knew about this policy, thank you for explaining it.

Michel Boaventura <michelboaventura>
Group Member
Fri 17 Jul 2020 06:10:59 PM UTC, comment #1: 

You are right that gimp is magnetudes slower than other tools, and in many respects is an overkill for this job.

However, this was a deliberate decision since gimp (like pspp) is a GNU project and the policy is to use other GNU tools where feasible.

Note that the converted icons are shipped with the distribution, so this will not affect users or anyone building from released versions.

John Darrington <jmd>
Group administrator
Fri 17 Jul 2020 04:47:43 PM UTC, original submission:  

While building a Docker image to automatically compile pspp I've realize gimp brings a lot of dependencies and slow down the build quite a bit. So I've changed `build-aux/svg2png` to use ImageMagick's convert instead.
I've tune it to give the same output as Gimp, and as can be seen on align-left-gimp.png and align-left-convert.png one really can't tell the difference. Besides reducing the number of dependencies, the time to run `make -f Smake icons` whent down from 80s to 6s!

Michel Boaventura <michelboaventura>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by michelboaventura (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-07-17 michelboaventura Open/ClosedOpen Closed
    2020-07-17 jmd StatusNone Wont Do
    2020-07-17 michelboaventura Attached File- Added gimp_to_imagemagick.patch, #49498
        Attached File- Added align-left-convert.png, #49499
        Attached File- Added align-left-gimp.png, #49500

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code