patchGNU nano - Patches: patch #9945, rename the parameters of all...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9945: rename the parameters of all prototypes so that they match their names in the definitions

Submitter:  Pedro Victor <pedrocga1>
Submitted:  Thu 18 Jun 2020 12:03:59 AM UTC
   
 
Priority:  3 - Low Status:  Done
Privacy:  Public Assigned to:  bens
Open/Closed:  Closed Release:  None

Thu 30 Jul 2020 07:20:17 AM UTC, comment #3: 

Released in nano-5.0.

Benno Schulenberg <bens>
Group administrator
Sat 20 Jun 2020 09:53:29 AM UTC, comment #2: 

Thanks for the patch (file #49326).

There were two more obsoleted prototypes, and your patch overlooked two changes of "kbinput" to "keycode".  I've adjusted those things, and then pushed the patch in commit 84b187f6.

Benno Schulenberg <bens>
Group administrator
Thu 18 Jun 2020 01:51:46 PM UTC, comment #1: 

As you say, it is irrelevant for the functioning of the program.  Also, this is not the only mismatch.  I would accept the patch if it fixes all of the current discrepancies.  There are about thirty of them.  You can check with:

grep ');$' src/proto.h | grep -v '^\s' | sed 's/;//' | sort >prototypes
grep -h -B1 '^\{$' src/*.c | grep ')$' | grep -v '^\s' | sort >actual-funcs
diff -u prototypes actual-funcs | less

(Also, a proper patch needs to have a Signed-off-by line.  See README.GIT.)

Benno Schulenberg <bens>
Group administrator
Thu 18 Jun 2020 12:03:59 AM UTC, original submission:  

One of the parameters of proto.h:parse_num had different names between the function's declaration and definition (utils.c).

It's irrelevant to the program, but there's no reason not to fix it, anyway.

Pedro Victor <pedrocga1>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Posted a comment)
  • -email is unavailable- added by pedrocga1 (Submitted the item)
  • -email is unavailable- added by pedrocga1
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-07-30 bens Open/ClosedOpen Closed
    2020-06-20 bens Summaryrename a parameter in function prototype so that it matches definition rename the parameters of all prototypes so that they match their names in the definitions
    2020-06-20 bens Priority1 - Later 3 - Low
        StatusDuplicate Done
        Assigned toNone bens
        Open/ClosedClosed Open
    2020-06-20 bens StatusNone Duplicate
        Open/ClosedOpen Closed
    2020-06-18 bens SummaryRenames a parameter in function declaration so that it matches definition rename a parameter in function prototype so that it matches definition
    2020-06-18 pedrocga1 Attached File- Added 0001-Rename-a-parameter-that-had-different-names-between-.patch, #49303
        Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code