patchGNU Octave - Patches: patch #9944, upgrade libbiosig to v2.0.4 in...

 
 

patch #9944: upgrade libbiosig to v2.0.4 in mxe-octave

Submitter:  Alois Schlögl <schloegl>
Submitted:  Wed 17 Jun 2020 09:08:36 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 25 Jun 2020 07:08:53 AM UTC, comment #7: 

All Windows buildbots are green.
Closing as done.

Markus Mützel <mmuetzel>
Group administrator
Tue 23 Jun 2020 06:11:51 PM UTC, comment #6: 

I pushed your updated .mk file (minus the whitespace changes) here:
https://hg.octave.org/mxe-octave/rev/3940a36c1aa6

Marking as ready for test while waiting for the results from the build bots.

Markus Mützel <mmuetzel>
Group administrator
Mon 22 Jun 2020 05:23:03 PM UTC, comment #5: 

Reading this thread on the Octave maintainers mailing list, I gathered the goal was to provide the necessary libraries for mexbiosig when a user installs Octave on Windows:
https://octave.1599824.n4.nabble.com/how-to-make-mexbiosig-work-on-mxe-octave-td4692672.html

With these libraries, a user should be able to install mexbiosig as a local package in Octave on Windows with the command you showed in your comment #4.

Is each version of mexbiosig only compatible with one single version (or range) of libbiosig?

Installing the current version (2.0.4) in Octave on Windows (built about 2 months ago, including libbiosig 2.0.1) seems to have succeeded. I don't know how to use the package though. So I didn't run any tests.

Imho, installing mexbiosig as a local (or global) package in Octave seems cleaner than copying the files to the host-prefix tree. But maybe we could leave these lines in as comments.

MXE Octave doesn't contain a target for stimfit. (Or did I mis-understand what you wrote?)

I just started a new cross-build of MXE Octave that includes the updated version and build rules for libbiosig. It might take a while before that has finished.
I'll push the changes to the repository if that succeeds.

Markus Mützel <mmuetzel>
Group administrator
Sun 21 Jun 2020 11:47:04 PM UTC, comment #4: 



attached is libbiosig v2.0.4. This is in line with the latest release of Biosig. This release could be used to extend support for Biosig further

1) mexbiosig can be build by uncommenting this line:

    TARGET='$(TARGET)' $(MAKE) -C '$(1)'/biosig4c++ mexbiosig

This will only build the package, but does not install it. It can be installed with

   pkg install https://pub.ist.ac.at/~schloegl/biosig/prereleases/mexbiosig-2.0.4.src.tar.gz
   pkg install .../biosig4c++/mex/mexbiosig-2.0.4.src.tar.gz

once octave is installed under windows. However, it is not clear to me whether this can be installed with mxe-biosig.


2) biosig4octmat (biosig for octave and matlab) could be installed by enabling these lines:

   $(INSTALL) -d $(HOST_PREFIX)/share/biosig/matlab
   cp -r '$(1)'/biosig4matlab/* $(HOST_PREFIX)/share/biosig/matlab/

In order to use it, the PATH would need to be setup (see biosig_installer.m), and its recommended that some other packages (signal, statistics, ..) are available as well.


3) The installation of some *.dll.a is disabled because this has caused problems under mxe (stimfit could not be build). I'm not sure whether this would be also a problem in mxe-octave.

Feel free to enable these.





(file #49340)

Alois Schlögl <schloegl>
Sat 20 Jun 2020 03:24:04 PM UTC, comment #3: 

I pushed a modified patch here:
https://hg.octave.org/mxe-octave/rev/65342965d7f8

Marking as ready for test.

Markus Mützel <mmuetzel>
Group administrator
Wed 17 Jun 2020 08:48:12 PM UTC, comment #2: 

I removed the patch and added a commit message in the attached patch.

I tried to build with it. But compilation fails.

I'm attaching the log file.
The last few lines in the log contain:

TARGET='x86_64-w64-mingw32' make -C '/home/osboxes/Documents/Repositories/Octave/mxe-octave/tmp-libbiosig/biosig-2.0.3' -j '4' libbiosig.a libgdf.a libphysicalunits.a libbiosig.def libgdf.def libphysicalunits.def
make[2]: Entering directory '/home/osboxes/Documents/Repositories/Octave/mxe-octave/tmp-libbiosig/biosig-2.0.3'
make[2]: *** No rule to make target 'libbiosig.a'.  Stop.
make[2]: Leaving directory '/home/osboxes/Documents/Repositories/Octave/mxe-octave/tmp-libbiosig/biosig-2.0.3'
make[1]: *** [/home/osboxes/Documents/Repositories/Octave/mxe-octave/Makefile:940: build-only-libbiosig] Error 2
make[1]: Leaving directory '/home/osboxes/Documents/Repositories/Octave/mxe-octave'


(file #49301, file #49302)

Markus Mützel <mmuetzel>
Group administrator
Wed 17 Jun 2020 09:10:47 AM UTC, comment #1: 

The patch upgrades libbiosig to v2.0.3 in mxe-octave.

The patch
   src/libbiosig-1-fixes.patch
becomes obsolete and should be removed too, as this is already incorported in libbiosig 2.0.3



Alois Schlögl <schloegl>
Wed 17 Jun 2020 09:08:36 AM UTC, original submission:  


Alois Schlögl <schloegl>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #49340:  libbiosig.mk added by schloegl (3KiB - text/x-makefile)
file #49302:  mxe_libbiosig203.patch added by mmuetzel (6KiB - application/octet-stream)
file #49301:  libbiosig added by mmuetzel (17KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Updated the item)
  • -email is unavailable- added by schloegl (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-06-25 mmuetzel StatusReady For Test Done
        Open/ClosedOpen Closed
    2020-06-23 mmuetzel StatusIn Progress Ready For Test
    2020-06-22 mmuetzel StatusReady For Test In Progress
        Summaryupgrade libbiosig to v2.0.3 in mxe-octave upgrade libbiosig to v2.0.4 in mxe-octave
    2020-06-21 schloegl Attached File- Added libbiosig.mk, #49340
    2020-06-20 mmuetzel StatusIn Progress Ready For Test
    2020-06-17 mmuetzel Attached File- Added libbiosig, #49301
        Attached File- Added mxe_libbiosig203.patch, #49302
        StatusNone In Progress
    2020-06-17 schloegl Attached File- Added patch-upgrade-libbiosig-v203.diff, #49297

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code