patchGNU Octave - Patches: patch #9756, [octave forge] (mapping) utmzone

 
 

patch #9756: [octave forge] (mapping) utmzone

Submitter:  None
Submitted:  Thu 07 Feb 2019 12:59:17 PM UTC
   
 
Category:  Forge : new function Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  philipnienhuis Originator Email:  -email is unavailable-
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 06 May 2019 06:44:56 PM UTC, comment #4: 

Pushed here:
http://hg.code.sf.net/p/octave/mapping/rev/d57f13cb39d7

Some notes:

  • Replaced several if-elseif-elseif sequences by nested switch stmts;
  • Implemented the two-output form (you just returned lat & lon in one output arg)
  • Parentheses around ALL if conditions + while condition
  • More rigid input checking


Again, thank you for your contribution, Anonymous. And sorry for a bit of waiting, but I'm quite busy lately.

Philip Nienhuis <philipnienhuis>
Group Member
Sat 16 Feb 2019 09:51:50 PM UTC, comment #3: 

Thank you for the response.


test utmzone
PASSES 7 out of 7 tests


 I added the switch hopefully it makes it more clear.
Let me know if I misses any of the style part.


(file #46285)

Anonymous
Thu 07 Feb 2019 09:49:34 PM UTC, comment #2: 

Looks like there is some code missing around L. 69/70 (where code indents extra).

Hint:
Replace repeated elseifs by a switch statement, makes the code much more transparent.

Philip Nienhuis <philipnienhuis>
Group Member
Thu 07 Feb 2019 09:22:10 PM UTC, comment #1: 

Reports a parse error near line 96.
Some style fixes are required, e.g. parentheses around if conditions (for example L.50), I think they may help you find the culprit.

Anyway I have little time now, but maybe it can shovec in the mapping pkg before the next release. (That is waiting for a new geometry + a matgeom package release BTW.)

FYI I started looking at projections using the OF proj package, I need those a.o. to properly display georeferenced raster maps. Maybe for the next after release of mapping. Several existing m-file implementations could benefit from this proj package as regards speed.

Philip Nienhuis <philipnienhuis>
Group Member
Thu 07 Feb 2019 12:59:17 PM UTC, original submission:  

This takes into account the special zones of Norway.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #46285:  utmzone.m added by None (4KiB - application/octet-stream)
file #46199:  utmzone.m added by None (4KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 6 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2019-05-06 philipnienhuis StatusNone Done
    Open/ClosedOpen Closed
2019-04-20 philipnienhuis Assigned toNone philipnienhuis
2019-03-07 mtmiller Summary[octave forge](mapping) utmzone [octave forge] (mapping) utmzone
2019-02-16 None Attached File- Added utmzone.m, #46285
2019-02-07 None Attached File- Added utmzone.m, #46199

Back to the top

Powered by Savane 3.13-f8d8.
Corresponding source code