patchGNU Octave - Patches: patch #9646, [octave forge] (linear-algebra)...

 
 

patch #9646: [octave forge] (linear-algebra) 2.2.3

Submitted by:  marco atzeri <matzeri>
Submitted on:  Fri 01 Jun 2018 01:37:35 PM UTC  
 
Category:  Forge : other Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Sun 10 Nov 2019 08:20:39 PM UTC, comment #12: 

(Turns out Marco Caliari is in the list of core developers, so I misused this patch report a bit to cc him.)

@Marco Caliari:
Do you think the funm code at

https://github.com/RickOne16/matrix/tree/master/funm

could replace the funm.m currently in the octave-forge linear-algebra package?
Mudit Sharma wrote in his GSOC application that

<quote>
The m-file script implementation of [3] is ready to be implemented in Octave, this work was done in mentorship provided by Prof Marco Caliari. Octave currently misses the JIT compiler due to which a C++ implementation of [3] will be done for funm.
</quote>

That C++ translation may not be needed yet. That might wait for when funm() ever moves into core Octave.

Philip Nienhuis <philipnienhuis>
Project Member
Sun 10 Nov 2019 07:28:32 PM UTC, comment #11: 

Philip -- sounds good. I added your patch meanwhile.

Nir Krakauer <nir_krakauer>
Fri 08 Nov 2019 08:40:05 PM UTC, comment #10: 

As to funm.m:

There is a much better version, see comment 32.

1. I tried it and it works, but my use cases (symmetric positive-definite matrices) are not so critical.
We might ask Marco Caliari if he thinks it could be included (for a 2.2.4 release I guess?)

2. That new funm code is m-files; the author stated that translation to C++ would be preferrable.

Philip Nienhuis <philipnienhuis>
Project Member
Fri 08 Nov 2019 08:36:30 PM UTC, comment #9: 

Here's the funm.m patch.
I wasn't in the cc list so I missed the discussions (just stumbled here from time to time)

(file #47824)

Philip Nienhuis <philipnienhuis>
Project Member
Fri 08 Nov 2019 06:22:28 PM UTC, comment #8: 

OK, I created a 2.2.3 release and submitted to the release tracker.

Nir Krakauer <nir_krakauer>
Fri 01 Nov 2019 09:04:09 PM UTC, comment #7: 

Now there are no warnings with Octave 5.1

Are there improvements to funm that should be incorporated for the next release, or are those already in the linear-algebra repo?

Nir Krakauer <nir_krakauer>
Fri 01 Nov 2019 07:57:31 PM UTC, comment #6: 

See bug #56996.
Nir has remove src/

Philip Nienhuis <philipnienhuis>
Project Member
Tue 24 Jul 2018 07:50:56 PM UTC, comment #5: 

real life took over
Happens to me all the time.

I didn't make a patch as it just for my own builds.
I think s/th along the lines of:
hg pull
hg -v update
## simply remove src/, fix INDEX, update DESCRIPTION and NEWS
hg ci -m "commit message"

should do the trick.

Will you have a look at funm.m? (comment #2)
I wanted to but probably have no time until September.

As I made the "original" "naive" funm.m in linear-algebra I have some interest.

Philip Nienhuis <philipnienhuis>
Project Member
Tue 24 Jul 2018 06:19:56 AM UTC, comment #4: 

Sorry, real life took over.
I agree with your proposal, do you need a patch for removing "src" ?

marco atzeri <matzeri>
Sun 15 Jul 2018 07:02:30 AM UTC, comment #3: 

Any plans for continuing this?

In my builds I have simply removed the complete src/ subdir from the package so it is an .m-file only package.
Both gsvd and pgmres are in stable octave and those in the linear-algebra package need several patches to compile with recent default.

Philip Nienhuis <philipnienhuis>
Project Member
Mon 04 Jun 2018 07:12:47 PM UTC, comment #2: 
Philip Nienhuis <philipnienhuis>
Project Member
Sat 02 Jun 2018 09:56:41 PM UTC, comment #1: 

see patch #8643 for some small typos

and comment in maintainers ML about shadowing pgmres and gsvd in core Octave.

Philip Nienhuis <philipnienhuis>
Project Member
Fri 01 Jun 2018 01:37:35 PM UTC, original submission:  

release 2.2.2 fail to build on octave 4.4

current repository code up to
changeset:   198:a9667cba7fd4
builds but warning are still present of
deprecated code.

The attached patches remove all warnings (tested on cygwin 64 bit)
and updated NEWs and Description for release

marco atzeri <matzeri>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #47824:  linalg_funm_fix.cset added by philipnienhuis (952B - application/octet-stream)
file #44268:  linear-algebra_clean.patch added by matzeri (4KiB - application/octet-stream)
file #44269:  linear-algebra_2.2.3News.patch added by matzeri (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by philipnienhuis
  • -email is unavailable- added by philipnienhuis
  • -email is unavailable- added by nir_krakauer (Posted a comment)
  • -email is unavailable- added by matzeri (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-11-10 philipnienhuis Carbon-Copy- => Added caliari
    2019-11-08 philipnienhuis Carbon-Copy- => Added philipnienhuis
    2019-11-08 philipnienhuis Attached File- => Added linalg_funm_fix.cset, #47824
    2019-03-07 mtmiller Summarylinear-algebra 2.2.3 => [octave forge] (linear-algebra) 2.2.3
    2018-06-01 matzeri Attached File- => Added linear-algebra_clean.patch, #44268
        Attached File- => Added linear-algebra_2.2.3News.patch, #44269

    Back to the top


    Powered by Savane 3.5