patchGNU Octave - Patches: patch #9518, [octave forge] (interval)...

 
 

patch #9518: [octave forge] (interval) configure.ac

Submitted by:  Olaf Till <i7tiol>
Submitted on:  Fri 15 Dec 2017 12:47:11 PM UTC  
 
Category: Forge : otherPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: NoneOpen/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 10 Jan 2018 05:05:10 PM UTC, comment #5:

Yes, we are happy with the new configure.ac.

https://sourceforge.net/p/octave/interval/ci/release-3.1.0/tree/src/configure.ac

Oliver Heimlich <oheim>
Wed 10 Jan 2018 01:12:18 PM UTC, comment #4:

Can this item get closed?

Kai Torben Ohlhus <siko1056>
Project Member
Sun 17 Dec 2017 12:24:59 PM UTC, comment #3:

Ok, I have re-added the check for libm

Oliver Heimlich <oheim>
Sun 17 Dec 2017 11:31:01 AM UTC, comment #2:

The check for libm pulled in libm into LIBS, without which the tests for fesetround and floor fail (without consequences in this configure.ac). You don't need to link the mpfr_... oct-files with libm because they are linked to Octave, and Octave already links with libm. But for the configure tests, the link to libm has to be done.

Instead of testing for libm, you could add the libm manually to LIBS (I wouldn't do that), or you could remove the tests for fesetround and floor also.

Olaf Till <i7tiol>
Project Member
Sat 16 Dec 2017 06:46:06 PM UTC, comment #1:

I have added configure.ac to the repository, but solved the other parts differently:

- The generated `configure` file is patched into the `hg archive` tarball (like several other generated files) with `tar --update`.

- Instead of a src/bootstrap script I have created a bootstrap target in the maintainer's Makefile

Thank you very much. I have already started to extend the configure.ac with further checks.

P.S. Was there a particular reason to include a check for libm? I have removed that check since libm is not used.

Oliver Heimlich <oheim>
Fri 15 Dec 2017 12:47:11 PM UTC, original submission:

added configure.ac to check for mpfr library

Olaf Till <i7tiol>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #42655:  configure.cset added by i7tiol (3KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by siko1056 (Posted a comment)
  • -unavailable- added by oheim (Posted a comment)
  • -unavailable- added by i7tiol (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 10 Jan 2018 09:43:05 PM UTCsiko1056StatusNeed Info=>Done
      Open/ClosedOpen=>Closed
    Wed 10 Jan 2018 01:12:18 PM UTCsiko1056StatusWorks For Me=>Need Info
    Fri 15 Dec 2017 12:47:12 PM UTCi7tiolAttached File-=>Added configure.cset, #42655

    Back to the top


    Powered by Savane 3.1-cleanup1