patchGNU Octave - Patches: patch #9492, mapping package: axes2ecc,...

 
 

patch #9492: mapping package: axes2ecc, flat2ecc, ecc2flat

Submitted by:  None
Submitted on:  Sat 18 Nov 2017 08:04:15 PM UTC  
 
Category: Forge : new functionPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Philip Nienhuis <philipnienhuis>Originator Email: -email is unavailable-
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 24 Jan 2018 09:25:48 PM UTC, comment #9:

Octave just uses GNU coding style. It's on the wiki:
http://wiki.octave.org/Octave_style_guide

That said I'm not perfect in following those either :-)

One of Gnievinski's m-files has been "ported" (re-coded in Octave style) by a GSOC? student and I've amended that quite a bit later on. But I don't know if I ever uploaded it to the relevant patch report.
Until the end of next week I have too little time to search.

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Wed 24 Jan 2018 09:01:54 PM UTC, comment #8:

Thank you for the addition.
I have looked at the differences and see where I can improve for next time.

There are many functions which have a lot of options, do these all need to be working before being submitted?

The key one is ellipsoid.
matlab states they support 60 types.

It looks like the wgs84 is the main one.
Viewing Nievinski's code get_ellipsoid has a lot of the information, but I do not know enough about structures to return the same results as matlab.

When I get free time again I will see what I can add/improve.

Anonymous
Wed 17 Jan 2018 10:13:48 PM UTC, comment #7:

After some stylistic changes, dropping majaxis and minaxis from one of the @seealso macros (as they arent't implemented yet), and a few more tests I pushed the three new functions to the repo here:
http://hg.code.sf.net/p/octave/mapping/rev/a6dc01667ec9

Again thanks for your contributions.

Closing this patch report.

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Sat 30 Dec 2017 10:57:42 PM UTC, comment #6:

Thanks, I'll be clearing the backlog slowly.

IIRC there were similar patches for geodesy functions in earlier patch reports, make sure you don't do double work. Many of those earlier patches haven't been included for various reasons, mostly lack of documentation and/or too many style problems, and maybe license issues, I forgot.

FYI, I was planning a new mapping pkg release soon, but I fear it may happen only after OctConf 2018 (if I go there at all) as I need to discuss a few issues with the geometry pkg maintainer (geometry = dependency of mapping). Last year a similar face-to-face discussion proved very fruitful.

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Sat 30 Dec 2017 05:49:17 AM UTC, comment #5:

Ok,

I have a version of flat2ecc and ecc2flat.
Since they are part of the [see also] section. I have added these here.

I will look into minaxis and majaxis and include these here as well. Unless you prefer patches for each function?

(file #42762, file #42763)

Anonymous
Sun 17 Dec 2017 10:05:08 AM UTC, comment #4:

The latter, sorry.

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Sat 16 Dec 2017 07:06:42 PM UTC, comment #3:

Do you need more information about the code?
Or are you busy with other things?

Anonymous
Sun 19 Nov 2017 09:32:10 PM UTC, comment #2:

Yes.

Anonymous
Sun 19 Nov 2017 07:34:36 PM UTC, comment #1:

Hi there,

are you the same guy (girl?) from patch #9475 (earthRadius) ?

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Sat 18 Nov 2017 08:04:15 PM UTC, original submission:

Note the vector ability will be removed in a future release of matlab.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #42762:  ecc2flat.m added by None (2KiB - text/x-objcsrc - additional functions)
file #42763:  flat2ecc.m added by None (2KiB - text/x-objcsrc - additional functions)
file #42427:  axes2ecc.m added by None (2KiB - text/x-objcsrc)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 9 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 17 Jan 2018 10:13:48 PM UTCphilipnienhuisCategoryNone=>Forge : new function
  StatusNeed Info=>Done
  Assigned toNone=>philipnienhuis
  Open/ClosedOpen=>Closed
  Summarymapping package:axes2ecc=>mapping package: axes2ecc, flat2ecc, ecc2flat
Sat 30 Dec 2017 05:49:17 AM UTCNoneAttached File-=>Added ecc2flat.m, #42762
  Attached File-=>Added flat2ecc.m, #42763
Sun 19 Nov 2017 07:34:36 PM UTCphilipnienhuisStatusNone=>Need Info
Sat 18 Nov 2017 08:04:15 PM UTCNoneAttached File-=>Added axes2ecc.m, #42427

Back to the top


Powered by Savane 3.1-cleanup1