patchGNU Octave - Patches: patch #9475, earthRadius mapping

 
 

patch #9475: earthRadius mapping

Submitted by:  None
Submitted on:  Sun 29 Oct 2017 10:02:56 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Philip Nienhuis <philipnienhuis>Originator Email: -unavailable-
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 04 Nov 2017 03:03:50 PM UTC, comment #7:

Pushed here:
http://hg.code.sf.net/p/octave/mapping/rev/1cdb724e550f

with a few style edits.
FYI, calling spheres_radius directly in the test won't work as it is a private function, so I adapted the test.

This will be part of a mapping-1.2.2 (or 1.4.0) release that I've been working on lately.

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Tue 31 Oct 2017 06:32:29 PM UTC, comment #6:

Yes, wonderful solution. Thank you for understanding.

Anonymous
Tue 31 Oct 2017 03:38:37 PM UTC, comment #5:

Credited is one thing, copyright string another.

When I push the function to the repo I won't attribute you in the commit message then, very well.

But there ought to be a real name in the copyright string because that has a legal meaning; "Anonymous" won't do.
If you find it also undesirable to have your name in the copyright string I think I'll put mine there and then attribute the function to "Anonymous" (something like "contributed by anonymous user" in the commit message). Would that be OK with you?

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Tue 31 Oct 2017 06:41:37 AM UTC, comment #4:

I do not desire to be credited. If this is a problem let me know.

If not, I will look to see if there are other functions I can help improve or create. Else this is my last contribution.

(file #42304)

Anonymous
Mon 30 Oct 2017 06:43:49 PM UTC, comment #3:

Right, thanks. I never used it so didn't know until now.

For inclusion in the mapping package the function needs a proper copyright statement, if possible in ascii (now I just see some gibberish on my us_EN system, see attached pic)
Would you like to be credited? If so would you disclose your name, please, optionally also email address?

(file #42302)

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Sun 29 Oct 2017 11:20:05 PM UTC, comment #2:

spheres_radius.m is located in
mapping-1.2.1/private/

This is part of the mapping package.

Anonymous
Sun 29 Oct 2017 10:46:12 PM UTC, comment #1:

thnks for this contribution.

The function calls "spheres_radius".
Where is that function supposed to be?

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Sun 29 Oct 2017 10:02:56 PM UTC, original submission:

returns the Earth's radius in the desired units

Please note in https://wiki.octave.org/Mapping_package
the functions
sm2deg
sm2km
sm2nm
sm2rad

already exist in mapping-1.2.1

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #42304:  earthRadius.m added by None (1KiB - text/x-objcsrc)
file #42295:  earthRadius.m added by None (1KiB - text/x-objcsrc)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 7 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 04 Nov 2017 03:03:50 PM UTCphilipnienhuisStatusIn Progress=>Done
  Open/ClosedOpen=>Closed
Tue 31 Oct 2017 09:06:46 PM UTCphilipnienhuisStatusNone=>In Progress
  Assigned toNone=>philipnienhuis
Tue 31 Oct 2017 06:41:37 AM UTCNoneAttached File-=>Added earthRadius.m, #42304
Mon 30 Oct 2017 06:43:49 PM UTCphilipnienhuisAttached File-=>Added patch_9475_copyright.PNG, #42302
Sun 29 Oct 2017 10:02:56 PM UTCNoneAttached File-=>Added earthRadius.m, #42295

Back to the top


Powered by Savane 3.1-cleanup1