patchGNU Octave - Patches: patch #9444, Better icon for variable editor...

 
 

patch #9444: Better icon for variable editor > Plot button

Submitter:  Alexander Wilms <alexanderw>
Submitted:  Fri 25 Aug 2017 09:10:40 PM UTC
   
 
Category:  Core : other Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  ttl Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 12 Oct 2017 05:14:22 AM UTC, comment #9: 

I have pushed the patch with changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/bdd4a8476c39

Torsten Lilge <ttl>
Group Member
Tue 10 Oct 2017 08:12:05 AM UTC, comment #8: 

Yes all combo boxes have their handle truncated indeed. See attached screenshot


Pantxo Diribarne <pantxo>
Group Member
Tue 10 Oct 2017 05:05:04 AM UTC, comment #7: 

Pantxo, does the truncation of the handle also happen with the pulldown menu in the file browser?

Torsten Lilge <ttl>
Group Member
Mon 09 Oct 2017 08:57:50 PM UTC, comment #6: 

I tested the patch and the icon looks very good, lets go for it.

On my system (mint 17.3), with or without the patch, the plot combo box has its handle (the down arrow at the right of the icon) truncated to the right. See attached screenshot.



Pantxo Diribarne <pantxo>
Group Member
Mon 09 Oct 2017 08:30:41 PM UTC, comment #5: 

@Pantxo: I have changed the colors to orange and sky blue from the tango theme (s. attached patch and png). Since the Octave gui offers to change the size of the icons and we are not (yet) distributing icon files in different sizes, 22px x 22px would be too small. All pngs are therefore exported in 128px x 128px, preventing the files from being up-sized.

file #42105)

Torsten Lilge <ttl>
Group Member
Mon 09 Oct 2017 09:18:58 AM UTC, comment #4: 

@Torsten: I like the colored icon. Maybe an orange and a sky blue line (#729fcf) would fit both Tango an Octave themes.
The size of the icon should also be smaller, (22px x 22px) as the OP's png:

http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines#Small


Pantxo Diribarne <pantxo>
Group Member
Mon 09 Oct 2017 04:47:43 AM UTC, comment #3: 

I have just seen that the png is not included in the patch. Here the file attached.


Torsten Lilge <ttl>
Group Member
Sun 08 Oct 2017 09:13:41 PM UTC, comment #2: 

That makes sense. It's a bit blurry right now, aligning the lines using Inkscape's snap to grid function would fix that, and if it's rendered at 22px size, then having the original svg at that size would be better.

Alexander Wilms <alexanderw>
Sun 08 Oct 2017 08:17:55 PM UTC, comment #1: 

Alexander, thank you for the patch.
However, I am hesitant adding an icon from an additional theme. Currently, we have the icons from the current desktop theme and - if not available - icons from the Tango theme. Icons not available in both sets are drawn based on the design rules from the Tango theme.

I have attached a revised patch with an icon created with colors and styles already used in some other icons. What do you think?

(file #42097)

Torsten Lilge <ttl>
Group Member
Fri 25 Aug 2017 09:10:40 PM UTC, original submission:  

I reused an icon from the Breeze theme.

Alexander Wilms <alexanderw>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #42109:  ComboBox.png added by pantxo (39KiB - image/png)
file #42104:  plot-xy-curve.png added by ttl (6KiB - image/png)
file #42105:  icon_v3.patch added by ttl (42KiB - text/x-patch)
file #42099:  plot-xy-curve.png added by ttl (7KiB - image/png)
file #42097:  icon_v2.patch added by ttl (42KiB - text/x-patch)
file #41660:  icon.patch added by alexanderw (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by pantxo (Posted a comment)
  • -email is unavailable- added by siko1056 (Updated the item)
  • -email is unavailable- added by ttl (Updated the item)
  • -email is unavailable- added by alexanderw (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 13 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-10-29 ttl StatusNone Done
        Open/ClosedOpen Closed
    2017-10-10 pantxo Attached File- Added ComboBox.png, #42109
    2017-10-09 pantxo Attached File- Added VariableEditorToolbar.png, #42106
    2017-10-09 ttl Attached File- Added plot-xy-curve.png, #42104
        Attached File- Added icon_v3.patch, #42105
    2017-10-09 ttl Attached File- Added plot-xy-curve.png, #42099
    2017-10-08 ttl Attached File- Added icon_v2.patch, #42097
    2017-10-08 siko1056 CategoryNone Core : other
    2017-08-27 ttl Assigned toNone ttl
    2017-08-25 alexanderw Attached File- Added icon.patch, #41660
        Attached File- Added labplot-xy-curve-segments.png, #41661
        Attached File- Added labplot-xy-curve-segments.svg, #41662

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code