patchGNU Octave - Patches: patch #9303, __makeinfo__ keeps temp file when...

 
 

patch #9303: __makeinfo__ keeps temp file when makeinfo printed to stderr

Submitter:  Juan Pablo Carbajal <juanpi>
Submitted:  Mon 27 Mar 2017 07:14:07 PM UTC
   
 
Category:  Core : new feature Priority:  5 - Normal
Status:  Wont Do Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 07 Mar 2019 01:34:09 AM UTC, comment #1: 

I don't think we'll apply this to Octave core, the temporary file is an implementation detail and shouldn't be left around or shown to the user under normal behavior.

I understand that this is probably related to building the doc-cache file when installing a pkg, right? In that context, all of the doc strings are processed at once and the user has no information about which function caused the error.

See patch #9464 to get an accurate pass/fail status from the '__makeinfo__' function.

After doing that, a further improvement might be to catch and report errors in the doc_cache_create function, which does know about the name of each function being processed.

Mike Miller <mtmiller>
Group Member
Mon 27 Mar 2017 07:14:07 PM UTC, original submission:  

Hi all,

It has been always quite difficult to track back errors on the texinfo block, therefore I have created this patch to prevent
_makeinfo_.m to delete the file if makeinfo printed to stderr (e.g. where 'misplaced }' is printed)

This allows us to go and look into the temp fiel to find the culprit of the problem. A better solution wouldbe to print the function name, but _makeinfo_ doesn't know that directly, and parsing the texinfo text itself seemed like too much work for a simple thing.

Hope you find it useful.

Juan Pablo Carbajal <juanpi>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #40172:  makeinfo_keep_tmp_file.cset added by juanpi (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by juanpi (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-07 mtmiller StatusNone Wont Do
        Open/ClosedOpen Closed
    2017-03-27 juanpi Attached File- Added makeinfo_keep_tmp_file.cset, #40172

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code