patchGNU Octave - Patches: patch #9054, octave-signal rms function

 
 

patch #9054: octave-signal rms function

Submitter:  Çağrı Özkan <chaozk>
Submitted:  Sun 17 Jul 2016 08:51:35 PM UTC
   
 
Category:  Forge : new function Priority:  5 - Normal
Status:  Duplicate Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 30 Mar 2018 01:54:48 AM UTC, comment #5: 

Closing as a duplicate of patch #8636, which is now merged.

Mike Miller <mtmiller>
Group Member
Wed 20 Jul 2016 10:42:59 AM UTC, comment #4: 

@Andreas Yes I had chance to look and overview my problem. However Im bit confused since the one #8636 not the same as in the nan or ltfat pack. I see on the post #8978 of rms it is not properly packed always. Under which package the #8636 implemented?

Çağrı Özkan <chaozk>
Mon 18 Jul 2016 06:38:13 PM UTC, comment #3: 

@Çağrı: Thank you for contributing, I didn't want to discourage you from submitting patches. I know it's disappoiting if your effort isn't recognized.

Have you had a look at the other implementation?
https://savannah.gnu.org/patch/?8636

Your implementation has some problems: it doesn't work for matrices and the second arg shouldn't be the length but the dimension for calculating rms on matrices.

Andreas Weber <andy1978>
Group Member
Mon 18 Jul 2016 06:01:16 PM UTC, comment #2: 

Sorry I didnt think about searching it thru the patches. I assumed it wasnt there since it wasnt in the pack. My bad.

Çağrı Özkan <chaozk>
Mon 18 Jul 2016 02:38:34 PM UTC, comment #1: 

This is the third patch on the patch tracker for "rms". Others are #8978 and #8636

Andreas Weber <andy1978>
Group Member
Sun 17 Jul 2016 08:51:35 PM UTC, original submission:  

It is not much but I wrote a matlab compatible RMS function. Mercurial repo is at https://bitbucket.org/chaozk/octave-signal
This is my first development try to octave, therefore I apologize if I didnt contribute properly.

Çağrı Özkan <chaozk>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by andy1978 (Posted a comment)
  • -email is unavailable- added by chaozk (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-07 mtmiller Carbon-CopyRemoved 80942 -
    2018-03-30 mtmiller StatusNone Duplicate
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code