patchGNU Octave - Patches: patch #9046, Add camera manipulation functions

 
 

patch #9046: Add camera manipulation functions

Submitted by:  Colin Macdonald <cbm>
Submitted on:  Mon 11 Jul 2016 07:51:14 AM UTC  
 
Category:  Core : new function Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 07 Oct 2017 08:44:45 PM UTC, comment #4: 

Thank you!

Colin Macdonald <cbm>
Sat 07 Oct 2017 06:22:08 PM UTC, comment #3: 

Colin, sorry for taking so long to review your patch.

I changed the line wrapping to 80 characters per line, added unwind_protect blocks around the tests to make sure the figure is closed in case the test results in an error, and fixed some pxrefs.
I omitted the changes to camlight because there seems no benefit in not accessing the properties directly.

Pushed here:
http://hg.savannah.gnu.org/hgweb/octave/rev/5ce4dfe5d906

Markus M├╝tzel <mmuetzel>
Project Member
Wed 13 Jul 2016 05:43:09 AM UTC, comment #2: 

Update.  This patch will now implement only the basic set/getter cam* methods:

campos, camtarget, camup, camva

Should be fairly straight-forward to review.  Please consider "camera_get_set_9046_v4.patch", ignore the others.

- - - - - - - - -

I've found some Matlab behaviour in the higher-level/smarter functions (camroll, camzoom, camorbit, etc) that I don't understand yet.  I will continue those in patch #9049.

(file #37839)

Colin Macdonald <cbm>
Tue 12 Jul 2016 09:05:05 PM UTC, comment #1: 

Summary so far:

  • 0000_cam_9046_v3.patch: campos, camtarget, camup, camva, camroll.  Renamed from v2, no changes to content.
  • 0001_camzoom_v1.patch: add camzoom
  • 0002_camorbit_v1.patch: add camorbit

(file #37829, file #37830, file #37831)

Colin Macdonald <cbm>
Mon 11 Jul 2016 07:51:14 AM UTC, original submission:  

I will attach a patch for campos, camtarget, camroll, camva, camup.

There are other cam* functions: perhaps others to follow, but these should be self-contained already.

Depends on camlight patch from #9014 (for camroll).

Colin Macdonald <cbm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #37839:  camera_get_set_9046_v4.patch added by cbm (21KiB - text/x-patch)
file #37836:  0002_camorbit_v2.patch added by cbm (10KiB - text/x-patch - (fixed typo, added xtest))
file #37829:  0000_cam_9046_v3.patch added by cbm (23KiB - text/x-patch)
file #37830:  0002_camorbit_v1.patch added by cbm (10KiB - text/x-patch)
file #37831:  0001_camzoom_v1.patch added by cbm (6KiB - text/x-patch)
file #37817:  cam_9046_v2.patch added by cbm (23KiB - text/x-patch - (fix "ax" problem in camroll, add tests, reformatting))
file #37800:  cam_9046_v1.patch added by cbm (21KiB - text/x-patch)

 

Depends on the following items

Digest:
   patch dependencies.

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by siko1056 (Updated the item)
  • -email is unavailable- added by cbm
  • -email is unavailable- added by cbm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 14 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-10-21 mmuetzel StatusReady For Test => Done
        Open/ClosedOpen => Closed
    2017-10-07 mmuetzel StatusNone => Ready For Test
    2016-07-13 siko1056 Dependencies- => patch #9049 is dependent
    2016-07-13 cbm Attached File- => Added camera_get_set_9046_v4.patch, #37839
    2016-07-13 cbm Attached File- => Added 0002_camorbit_v2.patch, #37836
    2016-07-12 siko1056 CategoryNone => Core : new function
    2016-07-12 siko1056 Dependencies- => Depends on patch #9014
    2016-07-12 cbm Attached File- => Added 0000_cam_9046_v3.patch, #37829
        Attached File- => Added 0002_camorbit_v1.patch, #37830
        Attached File- => Added 0001_camzoom_v1.patch, #37831
    2016-07-12 cbm Attached File- => Added cam_9046_v2.patch, #37817
    2016-07-11 cbm Attached File- => Added cam_9046_v1.patch, #37800
        Carbon-Copy- => Added mmuetzel

    Back to the top


    Powered by Savane 3.5