patchGnash - The GNU Flash player - Patches: patch #8908, Patch to make Gnash interpret path...


You are not allowed to post comments on this tracker with your current authentication level.

patch #8908: Patch to make Gnash interpret path in `GetVariable()` plugin function like ActionGetVariable

Submitted by:  Nutchanon Wetchasit <nachanon>
Submitted on:  Wed 10 Feb 2016 04:01:36 PM UTC  
Category:  core Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  Sandro Santilli <strk> Open/Closed:  Closed

Mon 15 Feb 2016 10:26:27 AM UTC, comment #2:

NOTE: one way to test the ScopeStack might be trying to trigger a concatenation of Flash->Javascript-Flash calls to see if the latter flash scope could access variables from the former. Your implementation should be using always a new stack for each invoke.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 15 Feb 2016 10:15:39 AM UTC, comment #1:

Pushed as commit 1d80521d4411e3c3959d9d96989ff9ac8fc36290

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 10 Feb 2016 04:01:36 PM UTC, original submission:

Current Gnash's `GetVariable()` plugin function implementation supports only
accessing variable using bare variable name. When HTML tries to use
slash-colon path to fetch variable, it failed. On Flash Player, slash-colon
path notation similar (if not the same) to ones used in ActionScript's
ActionGetVariable instruction is supported.

This patch changes `GetVariable()` implementation from using
`as_object::get_member()` to using Gnash's implementation of
ActionGetVariable on `_level0` timeline context; which supports both
bare variable name and slash-colon variable path; fixing bug #42395.

See the attached `0005_use-getvariable-action-path-in-plugin-function.patch`.

Once the patch is applied, `fontlist.html` test should give the
expected result, `getvariable-slashcolon.html` test should give the
mostly-correct result, and EFF Panopticlick
should show the fingerprint result properly too.

This might need a review since I'm not sure whether the way I used for
creating call stack was a proper one.

Gnash: 0.8.11dev (patched against git 435d3e9 6-Feb-2016) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

Nutchanon Wetchasit <nachanon>


Attached Files
file #36299:  0005_use-getvariable-action-path-in-plugin-function.patch added by nachanon (1KiB - text/x-diff - Patch to use ActionGetVariable implementation for handling `GetVariable()` plugin function)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by nachanon (Submitted the item)

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.




    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-02-15 strk StatusNone => Done
        Assigned toNone => strk
        Open/ClosedOpen => Closed
    2016-02-10 nachanon Attached File- => Added 0005_use-getvariable-action-path-in-plugin-function.patch, #36299

    Back to the top

    Powered by Savane 3.3