patchGNU Octave - Patches: patch #8842, Drop <project> tag from...

 
 

patch #8842: Drop <project> tag from appdata.xml

Submitted by:  Colin Macdonald <cbm>
Submitted on:  Wed 30 Dec 2015 08:44:45 AM UTC  
 
Category: NonePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 14 Nov 2016 06:13:15 PM UTC, comment #9:

I agree its not our bug.

But OTOH, I think it still effects us. E.g., in Fedora, we still (or at least recently) patch out "<project_group>GNU</project_group>".

Colin Macdonald <cbm>
Mon 14 Nov 2016 11:25:29 AM UTC, comment #8:

Colin, if I understood correctly the clarifications you got at https://github.com/hughsie/appstream-glib/issues/90 , limiting the project_group to gnome, kde, etc is a bug on the asglib implementation of the specs, that should not happen. Also, that the real specs are https://www.freedesktop.org/software/appstream/docs/ and not https://people.freedesktop.org/%7Ehughsient/appdata/

If so, can we close this as invalid?

Carnë Draug <carandraug>
Project Member
Fri 17 Jun 2016 04:39:34 PM UTC, comment #7:

Indeed, I filed this some time ago, asking them to clarify.

https://github.com/hughsie/appstream-glib/issues/90

I'll ping.

Colin Macdonald <cbm>
Fri 17 Jun 2016 03:20:04 PM UTC, comment #6:

Agree, until such time as the AppData specification is updated to reflect if it actually means something different than what we think it does.

According to https://people.freedesktop.org/~hughsient/appdata/

> If you include the <project_group> tag then this identifies your
> project with a specific upstream umbrella project. Known values
> include GNOME, KDE, XFCE, MATE and LXDE, although other umbrella
> projects like Yorba would make sense too.


it seems that any umbrella organization name should be valid here.

If that is not actually true, they should reword the spec to make it more clear that "project_group" actually must be one of an enumerated set of recognized "desktop" projects.

Mike Miller <mtmiller>
Project Administrator
Fri 17 Jun 2016 02:25:16 PM UTC, comment #5:

I'm still not happy with the situation here. The patch is needed for our appdata file to work with appstream but I think the bug is with them because they don't recognize GNU (actually, I'd arguee that the bug is that they have a whitelist of valid projects).

We shouldn't have to drop our affiliation with GNU just because appstream is not recognizing GNU as a project group.

Carnë Draug <carandraug>
Project Member
Tue 09 Feb 2016 09:19:53 AM UTC, comment #4:

Yes, you are right, sorry for the noise.

Colin Macdonald <cbm>
Tue 09 Feb 2016 01:49:32 AM UTC, comment #3:

What? That's not how I read the patch

https://github.com/hughsie/appstream-glib/commit/0c789c7623e6479e716e6a46a270080778743a5a

that fixed it

https://github.com/hughsie/appstream-glib/issues/73

I think the change they made was for appstream-util to really validate against their list of official project groups, so you will get an error validating instead of simply dropping it, and the GNU entry you see on the patch is adding is for a case test (broken.appdata.xml).

So this patch is still needed as long as they keep a list of official projects recognized by them.

Carnë Draug <carandraug>
Project Member
Sun 07 Feb 2016 09:54:00 PM UTC, comment #2:

Oops, I'm sorry I probably should've closed this as I think @hughsie fixed it so "GNU" is valid... I'll leave it open for now, wait and see the discussion from your and @orion's posts elswhere...

Colin Macdonald <cbm>
Sun 07 Feb 2016 09:33:23 PM UTC, comment #1:

According to AppData specification, https://people.freedesktop.org/~hughsient/appdata/ , the project_group tag description is:

> If you include the <project_group> tag then this identifies your project with a specific upstream umbrella project. Known values include GNOME, KDE, XFCE, MATE and LXDE, although other umbrella projects like Yorba would make sense too.
>
> NOTE:You should only identify with an umbrella project if you use all their infrastructure and policies, for instance string freezes dates, bugtracker and source control instance.


So our AppData file seems correct according to the specifications. GNU is not a desktop environment but that's not what this tag seems to be for.

It seems to me a bit silly that gnome software has a list of valid projects and would ignore all others. At least that's what I gathered from the comments at the redhat tracker you linked https://bugzilla.redhat.com/show_bug.cgi?id=1293561

Carnë Draug <carandraug>
Project Member
Wed 30 Dec 2015 08:44:45 AM UTC, original submission:

Without this, Octave is not shown in Gnome Software, e.g., on Fedora.

See downstream: https://bugzilla.redhat.com/show_bug.cgi?id=1293561

Should be applied to 4.0.1 and tip.

Colin Macdonald <cbm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by opoplawski
  • -unavailable- added by cbm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 30 Dec 2015 11:17:37 PM UTCopoplawskiCarbon-Copy-=>Added opoplawski
    Wed 30 Dec 2015 08:44:45 AM UTCcbmAttached File-=>Added drop-project-tag-from-appdataxml.patch, #35891

    Back to the top


    Powered by Savane 3.1-cleanup1