patchGnash - The GNU Flash player - Patches: patch #8765, Patch to make Gnash wait for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8765: Patch to make Gnash wait for return value in `ExternalInteface.call()`

Submitter:  Nutchanon Wetchasit <nachanon>
Submitted:  Fri 09 Oct 2015 10:20:47 AM UTC
   
 
Category:  core Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  strk Open/Closed:  Closed

Tue 15 Dec 2015 08:24:59 AM UTC, comment #2: 

In any case, I've pushed this patch with
commit ba67fb63be2392e25f3744391d8c6ff9f6d26565

Sandro Santilli <strk>
Group Member
Tue 15 Dec 2015 08:04:27 AM UTC, comment #1: 

It would be better to make the timeout value an RC directive, see libbase/rc.h.

Sandro Santilli <strk>
Group Member
Fri 09 Oct 2015 10:20:47 AM UTC, original submission:  

Currently, Gnash's implementation of `ExternalInteface.call()` used a
non-blocking read arrangement when it was trying to read a
return value message from host container, which (in most case, if not always)
caused it to miss the message, and returned `undefined` value to user's
ActionScript code instead of the expected return value.

This patch adds a `select()` call to make `ExternalInterface::readBrowser()`
wait for the message (up to 10 sec); partially fixing bug #46131.

The patch should not cause any other problem, as `ExternalInterface::readBrowser()`
is not used anywhere else in Gnash, and this is essentially what
the old code did, before non-blocking behavior was introduced.

Might need a review since I'm not very familiar with the `select()` function.

Gnash: 0.8.11dev (patched against git f0f66ce 23-Sep-2015) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

Nutchanon Wetchasit <nachanon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #35121:  0001_make-externalinterface-call-wait-for-container-return.patch added by nachanon (1KiB - text/x-patch - Patch to make Gnash wait for return value from host container)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by nachanon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-12-15 strk StatusNone Done
        Assigned toNone strk
        Open/ClosedOpen Closed
    2015-10-09 nachanon Attached File- Added 0001_make-externalinterface-call-wait-for-container-return.patch, #35121

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code