patchGNU Octave - Patches: patch #8695, A patch for function randsample in...

 
 

patch #8695: A patch for function randsample in statistics pkg

Submitted by:  doublevvinged <doublevvinged>
Submitted on:  Sat 27 Jun 2015 11:24:27 AM UTC  
 
Category: NonePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 04 Jul 2015 12:10:12 AM UTC, comment #2:

Some comments

  • your patch needs to follow octave coding guidelines. This means indenting the function block, explicit end (use endif, endfunction, etc), space after function names, use of # for comments, 2 space indentation.
  • why commented code? If you don't need it anymore, just remove it.
  • why did you remove the %! test blocks? These are formatted in a special way to be identified as tests by octave. Run "test randsample"
Carnë Draug <carandraug>
Project Member
Sat 04 Jul 2015 12:05:20 AM UTC, comment #1:

Adding maintainer of statistics package to cc

Carnë Draug <carandraug>
Project Member
Sat 27 Jun 2015 11:24:27 AM UTC, original submission:
doublevvinged <doublevvinged>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #34330:  mypatch.patch added by doublevvinged (8KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by carandraug (Arno Onken - maintainer of the statistics package)
  • -unavailable- added by doublevvinged (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 04 Jul 2015 12:05:20 AM UTCcarandraugCarbon-Copy-=>Added -unavailable-
    Sat 27 Jun 2015 11:24:27 AM UTCdoublevvingedAttached File-=>Added mypatch.patch, #34330

    Back to the top


    Powered by Savane 3.1-cleanup1