Gnash - The GNU Flash player - Patches: patch #8225, fix cppcheck reports for...

You are not allowed to post comments on this tracker with your current authentication level.

patch #8225: fix cppcheck reports for memtest.cpp

Submitter:	Julien Nabet <julien2412>
Submitted:	Tue 29 Oct 2013 07:23:13 PM UTC
Category:	testsuite	Priority:	5 - Normal
Status:	None	Privacy:	Public
Assigned to:	rsavoye	Open/Closed:	Open

Thu 31 Oct 2013 08:33:48 PM UTC, comment #1:  The memtest.cpp is not built by default. It seems to be a test for Memory class, which is only used by cygnal. Will leave this to Rob to look at.	Sandro Santilli <strk>
Tue 29 Oct 2013 07:23:13 PM UTC, original submission:   Hello, On git gnash sources retrieved today, cppcheck reported this: [testsuite/libbase.all/memtest.cpp:53]: (style) Variable 'diff' is assigned a value that is never used. [testsuite/libbase.all/memtest.cpp:98]: (style) Variable 'x' is allocated memory that is never used. [testsuite/libbase.all/memtest.cpp:80]: (warning) Logical disjunction always evaluates to true: diff >= 8 || diff <= 16. I attached a patch for fixing them. Julien	Julien Nabet <julien2412>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

file #29502:  memtest_patch.cpp added by julien2412 (1KiB - text/x-c++src)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List

-email is unavailable- added by strk (Posted a comment)

-email is unavailable- added by julien2412 (Submitted the item)

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Copyright © 2024 Free Software Foundation, Inc.
Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
Page source code