patchGNU nano - Patches: patch #7665, Fix memory errors in parse_syntax

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7665: Fix memory errors in parse_syntax

Submitter:  David Benjamin <davidben>
Submitted:  Tue 15 Nov 2011 03:37:34 PM UTC
   
 
Priority:  8 Status:  Done
Privacy:  Public Assigned to:  astyanax
Open/Closed:  Closed Release:  None

Thu 03 Jan 2013 05:19:49 AM UTC, comment #1: 

Hey David, apologies for the delay and thank you for the submission; that code was really badly wrong the way I'd initially done it!  This is included in r4560 and will be in nano 2.3.2, and I'll likely make a special release of 2.2 to include this fix.  I really appreciate this.

Chris Allegretta <astyanax>
Group administrator
Tue 15 Nov 2011 03:37:34 PM UTC, original submission:  

nano's code to remove duplicate syntaxtypes in the global syntax list leaves dangling pointers everywhere. This can cause a crash on startup or possibly corrupt other data structures. Instead, update the relevant linked list pointers.

Also plug a small memory leak. Deleting the syntaxtypes still leaks all the lists attached to the syntaxtype, but that's a more invasive patch.

David Benjamin <davidben>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #24380:  nano-duplicate-syntax.patch added by davidben (1KiB - text/x-patch - Fix memory errors in parse_syntax)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by astyanax (Posted a comment)
  • -email is unavailable- added by davidben (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-01-03 astyanax Priority5 - Normal 8
        StatusNone Done
        Assigned toNone astyanax
        Open/ClosedOpen Closed
    2011-11-15 davidben Attached File- Added nano-duplicate-syntax.patch, #24380

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code