Gnash - The GNU Flash player - Patches: patch #6151, Make flash version in description...
You are not allowed to post comments on this tracker with your current authentication level.
patch #6151: Make flash version in description consistent
Submitter: | Benjamin Wolsey <bwy> | ||
Submitted: | Thu 16 Aug 2007 07:05:50 AM UTC | ||
Category: | plugin | Priority: | 7 - High |
Status: | Done | Privacy: | Public |
Assigned to: | strk | Open/Closed: | Closed |
Jump to the original submission
Thu 13 Nov 2008 10:08:26 PM UTC, comment #7: |
Asher <asher> |
Fri 17 Aug 2007 06:07:54 PM UTC, comment #6: It seems the failure was in handling of a FlashParam, should be fixed now, apart from the getUrl opening the actual movie in a new firefox tab. I'd close this item, please open a new one for other problems. |
Sandro Santilli <strk> |
Fri 17 Aug 2007 02:48:52 PM UTC, comment #5: That should be www.forensis.com/FlashVersionDetector.html |
Anonymous |
Fri 17 Aug 2007 02:33:39 PM UTC, comment #4: The first patch only fixes theoretical bugs (as I say, I've never seen a website that requires a specific version number), but you can verify that the SWFobject javascript returns a value for revision with the attached html file. (rev is NaN before the patch).
|
Benjamin Wolsey <bwy> |
Fri 17 Aug 2007 02:03:03 PM UTC, comment #3: I tried using a 3 letter string for the name (in VM.cpp) and that fixed detection on kartoo.com.
|
Sandro Santilli <strk> |
Fri 17 Aug 2007 01:46:06 PM UTC, comment #2: Could you give a couple of URLS to try these detectors and verify your patch fixes them ? |
Sandro Santilli <strk> |
Fri 17 Aug 2007 12:41:18 PM UTC, comment #1: Change $version in VM.cpp to allow ActionScript player detection. This fixes the second issue in the original submission and should fix half of bug #19964 (I've explained why it doesn't on the bug).
|
Benjamin Wolsey <bwy> |
Thu 16 Aug 2007 07:05:50 AM UTC, original submission:
Defines FLASH_VERSION in plugin/plugin.cpp so that the version description is consistent. It thereby adds a revision number to the beginning of the plugin description so it can be detected by SWFobject.
|
Benjamin Wolsey <bwy> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 10 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-08-17 | strk | Status | Ready For Test | Done | |
Open/Closed | Open | Closed | |||
2007-08-17 | bwy | Attached File | - | Added SWFobject.html, #13678 | |
Attached File | - | Added fxnetworks_va.log, #13679 | |||
2007-08-17 | strk | Status | In Progress | Ready For Test | |
2007-08-17 | strk | Priority | 5 - Normal | 7 - High | |
Status | None | In Progress | |||
Assigned to | None | strk | |||
2007-08-17 | bwy | Attached File | - | Added ActionScript_version_detection.patch, #13676 | |
2007-08-16 | bwy | Attached File | - | Added plugin_description.patch, #13670 |
Powered by Savane 3.13-758e.
Corresponding source code
I have seen this same error for many months when loading GNASH in KARTOO.com. I'm not sure how to see the debug messages. Is this related to a combination of using adblocker as well as GNASH?
Please comment... thanks!