patchGNU Libtool - Patches: patch #10275, link-order.at: fix tests with GNU...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #10275: link-order.at: fix tests with GNU grep 3.8

Submitter:  Andreas Stieger <andreasstieger>
Submitted:  Sun 04 Sep 2022 08:37:51 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open

Thu 22 Sep 2022 12:47:48 PM UTC, comment #2: 

comment #1:

> Oh, I see I independently reported the bug and proposed a more-complete patch in patch #10202. Sorry about the duplication.


JFTR, the correct number is patch #10282

Santiago Ruano Rincón <santiago>
Mon 19 Sep 2022 08:32:45 PM UTC, comment #1: 

Oh, I see I independently reported the bug and proposed a more-complete patch in patch #10202. Sorry about the duplication.

Paul Eggert <eggert>
Sun 04 Sep 2022 08:37:51 PM UTC, original submission:  

Tests fail with GNU grep 3.8 due to a new warning introduced to stderr: Regular expressions with stray backslashes now cause warnings


[ 1902s] ./link-order.at:106: if $EGREP relinking stderr; then
[ 1902s]          $EGREP " -L.*\/new\/lib -lb -L.*\/old\/lib -lcee" stdout
[ 1902s]        else :; fi
[ 1902s] --- /dev/null 2022-09-04 15:44:09.608000000 +0000
[ 1902s] +++ /home/abuild/rpmbuild/BUILD/libtool-2.4.7/tests/testsuite.dir/at-groups/66/stderr 2022-09-04 15:50:25.548000000 +0000
[ 1902s] @@ -0,0 +1,4 @@
[ 1902s] +/usr/bin/grep: warning: stray \ before /
[ 1902s] +/usr/bin/grep: warning: stray \ before /
[ 1902s] +/usr/bin/grep: warning: stray \ before /
[ 1902s] +/usr/bin/grep: warning: stray \ before /
[ 1902s] stdout:
[ 1902s] libtool: warning: relinking 'src/liba.la'
[ 1902s] libtool: relink: gcc -shared  -fPIC -DPIC  src/.libs/a.o   -Wl,-rpath -Wl,/home/abuild/rpmbuild/BUILD/libtool-2.4.7/tests/testsuite.dir/066/new/lib -Wl,-rpath -Wl,/home/abuild/rpmbuild/BUILD/libtool-2.4.7/tests/testsuite.dir/066/old/lib -L/home/abuild/rpmbuild/BUILD/libtool-2.4.7/tests/testsuite.dir/066/new/lib -lb -L/home/abuild/rpmbuild/BUILD/libtool-2.4.7/tests/testsuite.dir/066/old/lib -lcee  -O2 -fstack-protector-strong -g   -Wl,-soname -Wl,liba.so.0 -o src/.libs/liba.so.0.0.0
[ 1902s] wrong link order
[ 1902s] 66. link-order.at:27: 66. Link order test (link-order.at:27): FAILED (link-order.at:106)

Patch tested with 3.7 and 3.8:

From 1e13a1944f725ccc24bce1a2fa6f9009ba8a2270 Mon Sep 17 00:00:00 2001
From: Andreas Stieger <Andreas.Stieger@gmx.de>
Date: Sun, 4 Sep 2022 22:24:41 +0200
Subject: [PATCH] tests/link-order.at: avoid warning and test failure with GNU
 grep 3.8

---
 tests/link-order.at | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/link-order.at b/tests/link-order.at
index 3f01a00d..a145347f 100644
--- a/tests/link-order.at
+++ b/tests/link-order.at
@@ -99,12 +99,12 @@ aix* | interix*) ;;  # These systems have different path syntax
   case $hardcode_direct$hardcode_direct_absolute in
   yesno)
     AT_CHECK([if $EGREP relinking stderr; then
-         $EGREP " .*\/new\/lib/libb$shared_ext .*\/old\/lib/libcee$shared_ext" stdout
+         $EGREP " .*/new/lib/libb$shared_ext .*/old/lib/libcee$shared_ext" stdout
        else :; fi], [0], [ignore], [], [echo "wrong link order"])
     ;;
   *)
     AT_CHECK([if $EGREP relinking stderr; then
-         $EGREP " -L.*\/new\/lib -lb -L.*\/old\/lib -lcee" stdout
+         $EGREP " -L.*/new/lib -lb -L.*/old/lib -lcee" stdout
        else :; fi], [0], [ignore], [], [echo "wrong link order"])
     ;;
   esac
--
2.37.2




Andreas Stieger <andreasstieger>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by santiago (Posted a comment)
  • -email is unavailable- added by eggert (Posted a comment)
  • -email is unavailable- added by andreasstieger (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    No changes have been made to this item

    Back to the top

    Powered by Savane 3.12