GNU Libtool - Patches: patch #10113, remove hard coded paths to...
You are not allowed to post comments on this tracker with your current authentication level.
patch #10113: remove hard coded paths to /usr/bin/file
Submitter: | Alex Ameen <growpotkin> | ||
Submitted: | Sat 02 Oct 2021 12:19:57 AM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | growpotkin | Open/Closed: | Closed |
Attached Files
Depends on the following items: None found
Items that depend on this one: None found
Carbon-Copy List
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2021-11-22 | growpotkin | Status | None | Done | |
Assigned to | None | growpotkin | |||
Open/Closed | Open | Closed | |||
2021-10-02 | growpotkin | Attached File | - | Added filecmd.patch, #52010 | |
Attached File | - | Added testsuite.log, #52011 | |||
Carbon-Copy | - | Added -email is unavailable- |
Powered by Savane 3.13-f8d8.
Corresponding source code
Hard coded paths which invoke file(cmd) fail on certain Linux distributions, in my case NixOS. I saw a commit from 1999 by Thomas Tanner <tanner@ffi.org> ( https://git.savannah.gnu.org/cgit/libtool.git/tree/libtool.m4?id=ef128a41ba1a3126f01b18054e7d4c5ca528f61c ) which used to call `AC_CHECK_TOOL(FILE` to handle this, I lost track of exactly when it was removed, but I assume it was dropped because other macros use `FILE` when performing compilation/linking checks.
This essentially restores Thomas Tanner <tanner@ffi.org> commit, but instead of using the name `FILE` I instead use `FILECMD`. I tried to follow patterns in use by other tools, but feel free to recommend any changes.
This passes everything in `make check` on my NixOS machine, except for `destdir.at`, `old-ltdl-iface.at`, `cmdline_wrap.at` which appear to be unrelated to my patch ( they fail on an unmodified build in my environment as well ). See attached testsuite.log.
This patch is against the "public" master branch, I will rewrite it against the private one for a merge.