bugGNU roff - Bugs: bug #63078, src/include/assert.h: withdraw the...

 
 

bug #63078: src/include/assert.h: withdraw the file

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Sun 18 Sep 2022 08:36:43 PM UTC
   
 
Category:  Core Severity:  1 - Wish
Item Group:  Build/Installation Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.23.0
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Fri 10 Feb 2023 03:15:05 PM UTC, comment #6: 

Thanks, Dave!

G. Branden Robinson <gbranden>
Group administrator
Fri 10 Feb 2023 01:23:04 AM UTC, comment #5: 

comment #3:

> See bug #63767 and bug #63744.


The second link should be bug #63774; 63744 is for a different project.

Dave <barx>
Group Member
Fri 10 Feb 2023 12:45:11 AM UTC, comment #4: 


commit ccc63e65c723e235fafc5099b383959c92664c38
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Thu Feb 9 16:43:09 2023 -0600

    src/include/assert.h: Delete.

    Switch to using system's assert.h header file.  It is futile to attempt
    to preserve compatibility with ISO C90 systems by providing a bespoke
    predicate-reporting assert() (a C99 feature) when gnulib, which we
    require, itself demands C99.  This ensures that `static_assert` remains
    defined so that gnulib can use it.  Thanks to Bruno Haible for the
    consultation.

    <https://lists.gnu.org/archive/html/groff/2023-02/msg00034.html>

    * src/include/assert.h: Delete.

    * src/devices/grodvi/dvi.cpp:
    * src/devices/grolbp/lbp.cpp:
    * src/devices/grolj4/lj4.cpp:
    * src/include/itable.h:
    * src/include/stringclass.h:
    * src/libs/libbib/linear.cpp:
    * src/libs/libbib/search.cpp:
    * src/libs/libdriver/printer.cpp:
    * src/libs/libgroff/assert.cpp:
    * src/libs/libgroff/color.cpp:
    * src/libs/libgroff/errarg.cpp:
    * src/libs/libgroff/font.cpp:
    * src/libs/libgroff/nametoindex.cpp:
    * src/libs/libgroff/prime.cpp:
    * src/libs/libgroff/relocate.cpp:
    * src/libs/libgroff/searchpath.cpp:
    * src/preproc/eqn/box.cpp:
    * src/preproc/eqn/delim.cpp:
    * src/preproc/eqn/pile.cpp:
    * src/preproc/eqn/script.cpp:
    * src/preproc/html/pre-html.cpp:
    * src/preproc/pic/pic.h:
    * src/preproc/preconv/preconv.cpp:
    * src/preproc/soelim/soelim.cpp:
    * src/roff/groff/groff.cpp:
    * src/roff/troff/troff.h:
    * src/utils/hpftodit/hpftodit.cpp:
    * src/utils/indxbib/indxbib.cpp:
    * src/utils/lkbib/lkbib.cpp:
    * src/utils/lookbib/lookbib.cpp:
    * src/utils/tfmtodit/tfmtodit.cpp: Respell "assert.h" inclusion with
      angle brackets instead of quotation marks.

    Fixes <https://savannah.gnu.org/bugs/?63078>.


G. Branden Robinson <gbranden>
Group administrator
Thu 09 Feb 2023 10:52:05 PM UTC, comment #3: 

Reopening.

Turns out my attempts at preserving support for ISO C90 systems was futile--gnulib already assumes C99.

See bug #63767 and bug #63744.

G. Branden Robinson <gbranden>
Group administrator
Mon 28 Nov 2022 11:24:07 PM UTC, comment #2: 

Closing after no response in two months.

Dave <barx>
Group Member
Mon 19 Sep 2022 07:10:20 PM UTC, comment #1: 


original submission:

> Subject: withdraw src/include/assert.h
>
>   This file caused a compilation error when I updated "gnulib".
>
>   See
> https://lists.gnu.org/archive/html/bug-gnulib/2022-09/msg00100.html
> (14th September) and later.
>
>   To avoid such occurrences the header files in "groff" should be updated
> with the corresponding "gnulib" header files or removed to use the system
> ones if applicable.
>


Nuh-uh.  Our assert.h is there in case the host system's is inadequate.  (ANSI C assertions were pretty anemic.)

You maintain your own personal branch of groff, which you do not disclose in your bug reports, and you have a history of inadequately cleaning your working copy amid (often ill-advised) local changes.

Paul Eggert is a competent developer and had no trouble building groff, as the thread reveals.

I will close this as invalid unless someone else can reproduce this problem.


G. Branden Robinson <gbranden>
Group administrator
Sun 18 Sep 2022 08:36:43 PM UTC, original submission:  

Subject: withdraw src/include/assert.h

  This file caused a compilation error when I updated "gnulib".

  See
https://lists.gnu.org/archive/html/bug-gnulib/2022-09/msg00100.html
(14th September) and later.

  To avoid such occurrences the header files in "groff" should be updated
with the corresponding "gnulib" header files or removed to use the system
ones if applicable.

Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by barx (Posted a comment)
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-02-10 gbranden StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2023-02-09 gbranden StatusUnreproducible In Progress
        Assigned tobarx gbranden
        Open/ClosedClosed Open
        Planned ReleaseNone 1.23.0
    2022-11-28 barx Assigned toNone barx
        Open/ClosedOpen Closed
    2022-09-19 gbranden Severity3 - Normal 1 - Wish
        StatusNone Unreproducible

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code