bugGNU Octave - Bugs: bug #62759, [octave forge] (optim) Remove...

 
 

bug #62759: [octave forge] (optim) Remove src/Makefile in distclean rule

Submitter:  Rafael Laboissière <rlaboiss>
Submitted:  Wed 13 Jul 2022 08:42:52 AM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * other Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 25 Jun 2023 10:17:55 AM UTC, comment #1: 

Applied here:

https://sourceforge.net/p/octave/optim/ci/85f16ae9ca751b2ee1fe704109a16493af52f4e3/

with changes:

Don't think "-" prefix is necessary, since $(RM) is used (rm -f) which doesn't have non-zero exit state for missing files.

Removed repetitions from distclean and maintainer-clean.

Thanks.

Olaf Till <i7tiol>
Group Member
Wed 13 Jul 2022 08:42:52 AM UTC, original submission:  

The src/Makefile should be removed in the distclean rule of src/Makefile.in. The patch attached to this bug report fixes this issue.

Furthermore, the patch adds prerequisites clean and distclean to the distclean and maintainer-clean rules, respectively, and precede the rm commands in the clean and maintainer-clean rules by the "-" prefix, such that make will not stop if some files have already been cleaned. Finally, maintainer-clean is added as prerequisite to the .PHONY target.

Rafael Laboissière <rlaboiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by i7tiol (Posted a comment)
  • -email is unavailable- added by rlaboiss (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-06-25 i7tiol StatusNone Fixed
        Open/ClosedOpen Closed
    2022-07-13 rlaboiss Attached File- Added remove-Makefile-in-distclean-rule.patch, #53431

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code