bugGNU Octave - Bugs: bug #61489, [octave forge] (octproj) Use...

 
 

bug #61489: [octave forge] (octproj) Use string literal in call to error() and warning() functions

Submitter:  Rafael Laboissière <rlaboiss>
Submitted:  Mon 15 Nov 2021 06:22:02 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * other Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 07 Nov 2022 12:52:15 PM UTC, comment #2: 

Afaict, this has been fixed in this commit:
https://bitbucket.org/jgpallero/octproj/commits/2430d8be5d11bb2047ea5343b4ff077e1977b8d8

Closing report.

Markus Mützel <mmuetzel>
Group administrator
Mon 07 Nov 2022 12:33:14 PM UTC, comment #1: 

Done

José Luis García Pallero <jgpallero>
Mon 15 Nov 2021 06:22:02 PM UTC, original submission:  

Compilation of the octclip package with option -Werror=format-security (a requirement for building Debian packages) fails with error messages like this:


_op_fwd.cc: In function ‘octave_value_list F_op_fwd(const octave_value_list&, int)’:
_op_fwd.cc:77:15: error: format not a string literal and no format arguments [-Werror=format-security]
   77 |         error(errorText);
      |               ^~~~~~~~~
_op_fwd.cc:123:25: error: format not a string literal and no format arguments [-Werror=format-security]
  123 |                 warning(errorText);
      |                         ^~~~~~~~~
_op_fwd.cc:139:23: error: format not a string literal and no format arguments [-Werror=format-security]
  139 |                 error(errorText);
      |                       ^~~~~~~~~
cc1plus: some warnings being treated as errors
make[1]: *** [Makefile:25: compile] Error 1


The patch attached to this bug report fixes the issue.

Rafael Laboissière <rlaboiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by jgpallero (Posted a comment)
  • -email is unavailable- added by philipnienhuis
  • -email is unavailable- added by rlaboiss (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-11-07 mmuetzel StatusNone Fixed
        Open/ClosedOpen Closed
    2022-01-05 philipnienhuis Carbon-Copy- Added jgpallero
    2021-11-15 rlaboiss Attached File- Added format-security-error.patch, #52284

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code