bugGNU Octave - Bugs: bug #61483, [octave forge] (octclip) Honor the...

 
 

bug #61483: [octave forge] (octclip) Honor the environment variables CFLAGS and CXXFLAGS

Submitter:  Rafael Laboissière <rlaboiss>
Submitted:  Sun 14 Nov 2021 04:48:49 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * other Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 07 Nov 2022 11:57:43 AM UTC, comment #8: 

Thanks. This effectively looks pretty similar to the original patch by rlaboiss in comment #0 now.

Closing as fixed.

Markus Mützel <mmuetzel>
Group administrator
Mon 07 Nov 2022 11:47:19 AM UTC, comment #7: 


comentario nº6:

> > so far I have not received any message about compilation errors on this topic. I prefer to maintain the flags
>
> IIUC, there hasn't been a release of the octclip package yet for which `-fstack-protector-strong` was added unconditionally.
> Or are you talking about other packages/projects?


Excuse me, I thought you are talking about not only the -fstack-protector-strong, but also about all the other compiler options. I've reverted the changes related to the addition of the compiler options related to the construction of the Debian package

José Luis García Pallero <jgpallero>
Mon 07 Nov 2022 11:41:22 AM UTC, comment #6: 


> so far I have not received any message about compilation errors on this topic. I prefer to maintain the flags


IIUC, there hasn't been a release of the octclip package yet for which `-fstack-protector-strong` was added unconditionally.
Or are you talking about other packages/projects?

Markus Mützel <mmuetzel>
Group administrator
Mon 07 Nov 2022 11:03:36 AM UTC, comment #5: 


comentario nº4:

> Afaict, CFLAGS is still overridden:
> https://bitbucket.org/jgpallero/octclip/src/13f95d171757aa62a99725b07a73cd4fb9522755/src/Makefile#lines-10


> CFLAGS=-std=c99 -pedantic $(FLAGSCOMW) -Wconversion -Wmissing-prototypes


You are right, thanks. I've corrected and upgraded the repo

>
> I'm also not sure if it is a good idea to force those hardening flags on all users. ISTR, that they can cause issues on some platforms (e.g., clang on MinGW?).


Yes, you are right again, but so far I have not received any message about compilation errors on this topic. I prefer to maintain the flags

José Luis García Pallero <jgpallero>
Mon 07 Nov 2022 10:53:43 AM UTC, comment #4: 

Afaict, CFLAGS is still overridden:
https://bitbucket.org/jgpallero/octclip/src/13f95d171757aa62a99725b07a73cd4fb9522755/src/Makefile#lines-10

CFLAGS=-std=c99 -pedantic $(FLAGSCOMW) -Wconversion -Wmissing-prototypes


I'm also not sure if it is a good idea to force those hardening flags on all users. ISTR, that they can cause issues on some platforms (e.g., clang on MinGW?).

Markus Mützel <mmuetzel>
Group administrator
Mon 07 Nov 2022 10:47:42 AM UTC, comment #3: 


comentario nº2:

> Afaict, this was partly fixed with this change:
> https://bitbucket.org/jgpallero/octclip/commits/02af79bbacc147115d39fe7bc9f598f2531d7816
>
> The CFLAGS are still overridden iiuc.


CFLAGS and CXXFLAGS have now the += assignation form, so any previous configuration won't be overwritten

>

José Luis García Pallero <jgpallero>
Mon 07 Nov 2022 10:43:58 AM UTC, comment #2: 

Afaict, this was partly fixed with this change:
https://bitbucket.org/jgpallero/octclip/commits/02af79bbacc147115d39fe7bc9f598f2531d7816

The CFLAGS are still overridden iiuc.

Markus Mützel <mmuetzel>
Group administrator
Mon 07 Nov 2022 10:22:36 AM UTC, comment #1: 

Done

José Luis García Pallero <jgpallero>
Sun 14 Nov 2021 04:48:49 PM UTC, original submission:  

The compilation of the C++ files of the octclip package ignore the setting of the environment variables CFLAGS and CXXFLAGS.

The patch attached to this bug report fixes the problem. It is being applied to the Debian package octave-octclip, such that hardening flags like -fstack-protector-strong, -Wformat, and -Werror=format-security are used in the compilation. (See https://wiki.debian.org/Hardening)

Rafael Laboissière <rlaboiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by jgpallero (Posted a comment)
  • -email is unavailable- added by rlaboiss (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-11-07 mmuetzel StatusNone Fixed
        Open/ClosedOpen Closed
    2021-11-14 rlaboiss Attached File- Added honor-cflags-cxxflags.patch, #52276

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code