bugGNU Octave - Bugs: bug #61205, [octave forge] (control) Test...

 
 

bug #61205: [octave forge] (control) Test failures with LAPACK 3.10.0

Submitter:  Sébastien Villemot <svillemot>
Submitted:  Wed 22 Sep 2021 10:09:03 AM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  None Assigned to:  None
Originator Name:  Open/Closed:  * Open
Release:  * other Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 17 Jan 2022 03:40:59 AM UTC, comment #5: 

Regarding comment #4:

OS: openSUSE 15.3
Octave: 6.4.0 (Docker)
OpenBLAS: 0.3.19
control 3.4.0 release candidate


clear all

pkg load control

## extracted from bstmodred.m

A =  [ -0.04165  0.0000  4.9200  -4.9200  0.0000  0.0000  0.0000
       -5.2100  -12.500  0.0000   0.0000  0.0000  0.0000  0.0000
        0.0000   3.3300 -3.3300   0.0000  0.0000  0.0000  0.0000
        0.5450   0.0000  0.0000   0.0000 -0.5450  0.0000  0.0000
        0.0000   0.0000  0.0000   4.9200 -0.04165 0.0000  4.9200
        0.0000   0.0000  0.0000   0.0000 -5.2100 -12.500  0.0000
        0.0000   0.0000  0.0000   0.0000  0.0000  3.3300 -3.3300 ];

B =  [  0.0000   0.0000
        12.500   0.0000
        0.0000   0.0000
        0.0000   0.0000
        0.0000   0.0000
        0.0000   12.500
        0.0000   0.0000 ];

C =  [  1.0000   0.0000  0.0000   0.0000  0.0000  0.0000  0.0000
        0.0000   0.0000  0.0000   1.0000  0.0000  0.0000  0.0000
        0.0000   0.0000  0.0000   0.0000  1.0000  0.0000  0.0000 ];

D =  [  0.0000   0.0000
        0.0000   0.0000
        0.0000   0.0000 ];

G = ss (A, B, C, D, "scaled", true);

[Gr, Info] = bstmodred (G, "beta", 1.0, "tol1", 0.1, "tol2", 0.0);
[Ao, Bo, Co, Do] = ssdata (Gr);

Ae = [  1.2729   0.0000   6.5947   0.0000  -3.4229
        0.0000   0.8169   0.0000   2.4821   0.0000
       -2.9889   0.0000  -2.9028   0.0000  -0.3692
        0.0000  -3.3921   0.0000  -3.1126   0.0000
       -1.4767   0.0000  -2.0339   0.0000  -0.6107 ];

Be = [  0.1331  -0.1331
       -0.0862  -0.0862
       -2.6777   2.6777
       -3.5767  -3.5767
       -2.3033   2.3033 ];

Ce = [ -0.6907  -0.6882   0.0779   0.0958  -0.0038
        0.0676   0.0000   0.6532   0.0000  -0.7522
        0.6907  -0.6882  -0.0779   0.0958   0.0038 ];

De = [  0.0000   0.0000
        0.0000   0.0000
        0.0000   0.0000 ];

HSVe = [  0.8803   0.8506   0.8038   0.4494   0.3973   0.0214   0.0209 ].';

Mo = [Ao, Bo; Co, Do];
Me = [Ae, Be; Ce, De];

save ("-v7", "bstmodred_test_data.mat")


Kai Torben Ohlhus <siko1056>
Group Member
Mon 17 Jan 2022 03:38:51 AM UTC, comment #4: 

As requested in the package release https://sourceforge.net/p/octave/package-releases/466/, find attached the computed matrices for the bstmodred.m test: file #52672

Kai Torben Ohlhus <siko1056>
Group Member
Sun 16 Jan 2022 07:45:56 PM UTC, comment #3: 

It looks like the resulting state space representations that differ from the expected ones still describe the very same dynamical system. I am wondering whether it would be more meaningful to compare the transfer matrices instead of of the (non unique) state space representations.

Torsten Lilge <ttl>
Group Member
Mon 10 Jan 2022 08:11:16 PM UTC, comment #2: 

Those are also failing with rc1 7.0.90 on Windows.

Dmitri A. Sergatskov <dasergatskov>
Wed 22 Sep 2021 10:55:25 AM UTC, comment #1: 

Actually the test in cfconred.m also fails in a similar way on some platforms (arm64, ppc64el, s390x at least), see:
https://buildd.debian.org/status/fetch.php?pkg=octave-control&arch=arm64&ver=3.3.1-3&stamp=1632307588&raw=0

Sébastien Villemot <svillemot>
Wed 22 Sep 2021 10:09:03 AM UTC, original submission:  

Hi,

Six tests of the control package fail after the upgrade to LAPACK 3.10.0:
- one test in btaconred.m
- one test in btamodred.m
- three tests in moen4.m
- one test in hnamodred.m

I attach a Debian build log that shows all the test results.

Those are apparently only sign changes, most likely due to the fact that LAPACK returns another (but still) valid solution than the one that is hardcoded in the test cases. In particular, I have observed that in LAPACK 3.10.0 the SVD routines can return singular vectors with the opposite sign compared to LAPACK 3.9.

Sébastien Villemot <svillemot>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #52672:  bstmodred_test_data.mat added by siko1056 (3KiB - application/octet-stream)
file #51952:  octave-control_3.3.1-2_amd64.build added by svillemot (316KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by siko1056 (Updated the item)
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by dasergatskov (Posted a comment)
  • -email is unavailable- added by svillemot (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-17 siko1056 Attached File- Added bstmodred_test_data.mat, #52672
    2021-09-22 svillemot Attached File- Added octave-control_3.3.1-2_amd64.build, #51952

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code