bugWebSTUMP - Bugs: bug #59455, Incorrect error message in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #59455: Incorrect error message in submission.pl

Submitter:  Rayner Lucas <rayner>
Submitted:  Thu 12 Nov 2020 09:15:02 PM UTC
   
 
Category:  None Severity:  2 - Minor
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  rayner
Open/Closed:  Closed

Fri 04 Dec 2020 04:08:04 AM UTC, comment #2: 

The bug is actually in the STUMP code, so I should have filed the report there, but never mind.

It's fine to have messages coming in to the submission address that don't have a Newsgroups header, as this is needed so people can submit posts by mail.

I have changed the message to use the MAX_CROSSPOSTS value.

Rayner Lucas <rayner>
Group Member
Fri 13 Nov 2020 11:22:52 AM UTC, comment #1: 


original submission:

> However, is this behaviour what we actually want? If we somehow get a message to the submission address that doesn't have the right newsgroup in the Newsgroup header, is it better to try to fix the message or just reject it outright?


I don't see how we can automatically fix it. If there are too many newsgroups specified in the article (either as originally submitted, or once we add the correct newsgroup to the header), then we can't post it as-is, and apart from removing any duplicates, we can't arbitrarily decide which newsgroup(s) to drop in order to get it under the threshold.

IMHO we should just reject these submissions, though of course the rejection message needs to be changed so that it uses MAX_CROSSPOSTS rather than the fixed string "FIVE".

Tristan Miller <psychonaut>
Group administrator
Thu 12 Nov 2020 09:15:02 PM UTC, original submission:  

If a message arrives to the submission address, but the newsgroup name set in modenv does not match anything in the Newsgroups header, the message-processing code adds the newsgroup to the Newsgroups header. It then checks if the message is now crossposted to too many groups.

If so, it prints "Too many newsgroups" to stderr, and runs the command:

processRejected robomod_Reject crosspost Too many newsgroups, FIVE is maximum.

The code for this is in the checkNewsgroups function in bin/submission.pl.

The straightforward part of the problem is that the rejection text is hardcoded as FIVE, whereas the maximum number of crossposts is actually set using MAX_CROSSPOSTS in the modenv script.

However, is this behaviour what we actually want? If we somehow get a message to the submission address that doesn't have the right newsgroup in the Newsgroup header, is it better to try to fix the message or just reject it outright?

Rayner Lucas <rayner>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psychonaut (Posted a comment)
  • -email is unavailable- added by rayner (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-12-04 rayner StatusNone Fixed
        Assigned toNone rayner
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code