bugGNU Octave - Bugs: bug #57938, [octave forge] (video) error:...

 
 

bug #57938: [octave forge] (video) error: declaration of 'panic' has a different language linkage

Submitter:  Marius Schamschula <mschamschula>
Submitted:  Mon 02 Mar 2020 01:12:54 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  andy1978
Originator Name:  Open/Closed:  * Closed
Release:  * other Operating System:  * Mac OS
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 23 Nov 2021 12:17:24 PM UTC, comment #11: 

Thanks!
Like I've already wrote, I don't know which bug this change is supposed to fix. So, I don't know if it is worth making a new release just for that.
I guess we could just leave the patch in MXE Octave until the next release of the video package...

Markus Mützel <mmuetzel>
Group administrator
Tue 23 Nov 2021 11:55:02 AM UTC, comment #10: 

yes, sure. Added here: https://sourceforge.net/p/octave/video/ci/d0cbe1b99d78f6ef552cb914cd99dcdd29f72572/tree/src/configure.ac?diff=52bc30dfa4521fb0edfd9dd7dbd90bce5dd2d832

Do I have to increase also the VERSION? I think a new release wouldn't be needed, isn't it?

Andreas Weber <andy1978>
Group Member
Tue 23 Nov 2021 08:50:59 AM UTC, comment #9: 

OT:
@andy1978: Since you are currently working on the video package:
There is a patch in MXE Octave that renames the "HAVE_MKOCTFILE" variable in the "mkoctfile" check to "MKOCTFILE":
https://hg.octave.org/mxe-octave/file/tip/src/of-video-1-fixes.patch

I don't understand what it is about or why it is needed. But it was originally added by jwe here:
https://hg.octave.org/mxe-octave/rev/3d2263062bbd

Would you like to adopt that change in your package?

IIUC, it boils down to:

diff -ur video-2.0.0.orig/src/configure.ac video-2.0.0/src/configure.ac
--- video-2.0.0.orig/src/configure.ac        2020-03-04 11:23:26.508419633 -0500
+++ video-2.0.0/src/configure.ac        2020-03-04 12:18:54.007562316 -0500
@@ -12,8 +12,8 @@
 # Define macros needed for libav
 #AC_DEFINE(__STDC_CONSTANT_MACROS, [], [workaround for C++ programs to use C99 macros])

-AC_CHECK_PROG([HAVE_MKOCTFILE], [mkoctfile], [yes], [no])
-if [test $HAVE_MKOCTFILE = "no"]; then
+AC_CHECK_PROG([MKOCTFILE], [mkoctfile], [yes], [no])
+if [test "$MKOCTFILE" = "no"]; then
   AC_MSG_ERROR([mkoctfile required to install $PACKAGE_NAME])
 fi


Markus Mützel <mmuetzel>
Group administrator
Tue 23 Nov 2021 06:51:21 AM UTC, comment #8: 

Thank you for the release Kai,
closing as fixed.

Andreas Weber <andy1978>
Group Member
Mon 22 Nov 2021 08:52:06 AM UTC, comment #7: 

@andy1978: Thank you for the very quick response 🙂  Indeed GNU Savannah is a Savanna regarding overview... If you want to see more open items about you package please visit and update GNU Savannah to your needs:

https://octave.space/savannah/?Action=get&OpenClosed=open&Format=HTMLCSS&Keywords=%5Boctave%20forge%5D%20(video)

However, please take your time and do not feel rushed by me 😉

I take care of the package release soon (latest tomorrow).  Sorry for the additional delay.

Kai Torben Ohlhus <siko1056>
Group Member
Mon 22 Nov 2021 08:44:33 AM UTC, comment #6: 

@Kai this is the first time I see this report, thanks for taking care to notify me.

I've added the patch here https://sourceforge.net/p/octave/video/ci/2.0.1/tree/

and requested a bugfix release with version 2.0.1 here:
https://sourceforge.net/p/octave/package-releases/456/

Andreas Weber <andy1978>
Group Member
Mon 22 Nov 2021 01:19:00 AM UTC, comment #5: 

According to https://gnu-octave.github.io/packages/video @andy1978 is the maintainer of this package.

Probably he was not notfied (done by this post).

Kai Torben Ohlhus <siko1056>
Group Member
Mon 22 Nov 2021 12:32:35 AM UTC, comment #4: 

I can confirm that the latest patch (#50556) is working perfectly on macOS Monterrey. Any chance this can be merged? It's been almost two years now with this package broken on Mac.

Joseph <josephtico>
Wed 23 Dec 2020 03:57:13 PM UTC, comment #3: 

Indeed! With a little experimentation, I needed two more mach headers, I got it to work.

(file #50556)

Marius Schamschula <mschamschula>
Wed 23 Dec 2020 09:09:39 AM UTC, comment #2: 

It might be best to try and avoid including the header with the conflicting declaration.

Could you try compiling the "video" package with the attached patch?
I don't have a Mac and can't test. So it is very well possible that more headers need to be included for other used functions.


(file #50555)

Markus Mützel <mmuetzel>
Group administrator
Sun 20 Dec 2020 09:15:32 PM UTC, comment #1: 

MacPorts just updated Octave to version 6.1.0, andI'm in the process of updating the packages. This problem has not gone away.

However, I see that there was a similar issue with Octave itself in 2015:
https://octave.1599824.n4.nabble.com/Default-does-not-compile-anymore-on-Mac-OS-td4674114.html

I've tried setting the problematic #includes in cap_ffmpeg_impl_ov.hpp to extern "C", but to no avail.

Can someone please help me to resolve this?

Marius Schamschula <mschamschula>
Mon 02 Mar 2020 01:12:54 PM UTC, original submission:  

While building the octave video package 2.0.0 under MacPorts (Mojave), I get the following error:


/usr/bin/clang++ -c -I/opt/local/include -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk -fPIC -I/opt/local/include/octave-5.2.0/octave/.. -I/opt/local/include/octave-5.2.0/octave -I/opt/local/include  -D_THREAD_SAFE -pthread -pipe -Os -std=c++11 -stdlib=libc++ -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk -arch x86_64  -Wall -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk  -I/opt/local/include  -DPACKAGE_NAME="Octave-Forge video package" -DPACKAGE_TARNAME="octave-forge-video-package" -DPACKAGE_VERSION="2.0.0" -DPACKAGE_STRING="Octave-Forge video package 2.0.0" -DPACKAGE_BUGREPORT="" -DPACKAGE_URL="" cap_ffmpeg_wrapper.cc -o /opt/local/var/macports/build/_Users_marius_Development_MacPorts_ports_math_octave-video/octave-video/work/.tmp/oct-uhPe64.o
In file included from cap_ffmpeg_wrapper.cc:18:
In file included from ./cap_ffmpeg_impl_ov.hpp:139:
/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/mach/mach.h:86:33: error: declaration of 'panic' has a different language linkage
extern void                     panic(const char *, ...);
                                ^
/opt/local/include/octave-5.2.0/octave/error.h:134:6: note: previous declaration is here
void panic (const char *fmt, ...);
     ^
1 error generated.
make: *** [cap_ffmpeg_wrapper.oct] Error 1

pkg: error running `make' for the video package.


Full log attached.

Marius Schamschula <mschamschula>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #50556:  patch-src-cap_ffmpeg_impl_ov.hpp.diff added by mschamschula (854B - application/octet-stream)
file #48532:  octave-video-main.log added by mschamschula (959KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by andy1978 (Posted a comment)
  • -email is unavailable- added by josephtico (Posted a comment)
  • -email is unavailable- added by mmuetzel (Updated the item)
  • -email is unavailable- added by siko1056 (Updated the item)
  • -email is unavailable- added by mschamschula (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-11-23 andy1978 StatusPatch Reviewed Fixed
        Open/ClosedOpen Closed
    2021-11-22 siko1056 StatusPatch Submitted Patch Reviewed
    2021-11-22 siko1056 StatusNone Patch Submitted
        Assigned toNone andy1978
    2020-12-23 mschamschula Attached File- Added patch-src-cap_ffmpeg_impl_ov.hpp.diff, #50556
    2020-12-23 mmuetzel Attached File- Added bug57938_panic_MacOS.patch, #50555
        Release5.2.0 other
    2020-03-02 siko1056 Summaryerror: declaration of 'panic' has a different language linkage [octave forge] (video) error: declaration of 'panic' has a different language linkage
    2020-03-02 mschamschula Attached File- Added octave-video-main.log, #48532

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code