bugGNU Octave - Bugs: bug #57084, some example invocations for...

 
 

bug #57084: some example invocations for dbstop misplaced

Submitter:  A.R. Burgers <arb>
Submitted:  Sat 19 Oct 2019 11:32:06 AM UTC
   
 
Category:  Documentation Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Documentation
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 23 Oct 2019 12:18:19 AM UTC, comment #2: 

I just deleted the two mysterious lines.  See https://hg.savannah.gnu.org/hgweb/octave/rev/ca4ab81a5601.


Rik <rik5>
Group administrator
Sun 20 Oct 2019 05:13:49 PM UTC, comment #1: 

This just looks like a typo to me and the two lines which refer to waveClass could be deleted.  The changeset that introduced these was


changeset:   26954:6e50f1fedeb5
user:        John W. Eaton <jwe@octave.org>
date:        Wed Mar 20 18:57:23 2019 +0000
files:       libinterp/corefcn/debug.cc libinterp/parse-tree/bp-table.cc libinterp/parse-tree/bp-table.h
description:
dbstop: accept "at CLASS in METHOD" syntax (partial fix for bug #45404)

* bp-table.h, bp-table.cc (bp_table::parse_dbfunction_params): New
parameter CLASS_NAME.  Attempt to accept "at CLASS in METHOD" syntax.
Change all uses.

* debug.cc (Fdbstop): Update docstring.


diff -r 6e01e5be8de3 -r 6e50f1fedeb5 libinterp/corefcn/debug.cc
--- a/libinterp/corefcn/debug.cc        Wed Mar 20 11:24:07 2019 -0700
+++ b/libinterp/corefcn/debug.cc        Wed Mar 20 18:57:23 2019 +0000
@@ -90,10 +90,13 @@ DEFMETHOD (dbstop, interp, args, ,
 @deftypefnx {} {} dbstop in @var{func}
 @deftypefnx {} {} dbstop in @var{func} at @var{line}
 @deftypefnx {} {} dbstop in @var{func} at @var{line} if "@var{condition}"
+@deftypefnx {} {} dbstop in @var{class} at @var{method}
 @deftypefnx {} {} dbstop if @var{event}
 @deftypefnx {} {} dbstop if @var{event} @var{ID}
 @deftypefnx {} {} dbstop (@var{bp_struct})
 @deftypefnx {} {@var{rline} =} dbstop @dots{}
+dbstop in waveClass at waveClass.plotEta
+dbstop waveClass at waveClass.plotEta


I've added jwe to the CC list so he can confirm whether they can be culled.

Rik <rik5>
Group administrator
Sat 19 Oct 2019 11:32:06 AM UTC, original submission:  

The dbstop help looks not completely right, the examples for stopping in a class seem to be misplaced. The downside of the @var{} decoration is that the capitalization of e.g. waveClass is lost since @var{} displays as all caps.


diff -r 1dbe839bedcb libinterp/corefcn/debug.cc
--- a/libinterp/corefcn/debug.cc        Fri Oct 18 17:24:37 2019 -0700
+++ b/libinterp/corefcn/debug.cc        Sat Oct 19 13:22:32 2019 +0200
@@ -93,9 +93,9 @@
 @deftypefnx {} {} dbstop if @var{event}
 @deftypefnx {} {} dbstop if @var{event} @var{ID}
 @deftypefnx {} {} dbstop (@var{bp_struct})
+@deftypefnx {} {} dbstop in @var{waveClass} at @var{waveClass.plotEta}
+@deftypefnx {} {} dbstop @var{waveClass} at @var{waveClass.plotEta}
 @deftypefnx {} {@var{rline} =} dbstop @dots{}
-dbstop in waveClass at waveClass.plotEta
-dbstop waveClass at waveClass.plotEta

 Set breakpoints for the built-in debugger.


A.R. Burgers <arb>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by rik5
  • -email is unavailable- added by arb (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-10-23 rik5 StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2019-10-20 rik5 StatusNone In Progress
        Carbon-Copy- Added jwe

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code