bugmake - Bugs: bug #56025, .RECIPEPREFIX doesn't parse line...

 
 

bug #56025: .RECIPEPREFIX doesn't parse line continuations inside function calls

Submitter:  John F. Trudeau <jftrudeau>
Submitted:  Thu 28 Mar 2019 08:09:13 PM UTC
   
 
Severity:  3 - Normal Item Group:  Bug
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
Component Version:  4.2.1 Operating System:  POSIX-Based
Fixed Release:  None Triage Status:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 13 May 2019 10:40:16 PM UTC, comment #3: 

Making the prefix visible is a good idea.  I think that it is more compelling if every line is prefixed.  It creates a good contrast between recipe lines and multi-line variable definitions.

Having to leave off a prefix or two is not to bad.

I didn't notice that blank lines were allowed in recipes.  (i.e. I never read to the end of the paragraph.)  Blank lines introduce deceptive visual breaks, where a visible prefix provides continuity.

Thanks for the consideration.

John F. Trudeau <jftrudeau>
Mon 13 May 2019 03:50:06 AM UTC, comment #2: 

I agree that this is not right.  The handling of the prefix character needs a bit of work.

However, I should say that I intended the prefix character to ONLY be used to introduce the initial line of a recipe.  Maybe that intention needs some rethought.

I'll leave this open to consider it.

Paul D. Smith <psmith>
Group administrator
Thu 28 Mar 2019 08:16:20 PM UTC, comment #1: 

I now realize that the TAB, could be inserted, and then removed by filter-out.

John F. Trudeau <jftrudeau>
Thu 28 Mar 2019 08:09:13 PM UTC, original submission:  

The default .RECIPEPREFIX (TAB) allows line continuation inside function calls.

Setting .RECIPEPREFIX causes the prefix to be inserted into the macro argument.

The attached "prefix.make" demonstrates this behavior.
"prefix.log" is the output.

I tried several different prefix characters with the same result.

John F. Trudeau <jftrudeau>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #46656:  prefix.log added by jftrudeau (30KiB - application/octet-stream)
file #46657:  prefix.make added by jftrudeau (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by jftrudeau (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-28 jftrudeau Attached File- Added prefix.log, #46656
        Attached File- Added prefix.make, #46657

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code