bugGNU Octave - Bugs: bug #55804, [octave forge] (video) Honor...

 
 

bug #55804: [octave forge] (video) Honor CXXFLAGS when building the *.oct files

Submitter:  Rafael Laboissière <rlaboiss>
Submitted:  Fri 01 Mar 2019 05:04:27 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  Patch Submitted Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * other Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 11 Mar 2020 02:49:56 PM UTC, comment #2: 

There is a new video release 2.0.0 and I guess this can be closed now

https://sourceforge.net/p/octave/video/ci/default/tree/

Andreas Weber <andy1978>
Group Member
Fri 01 Mar 2019 06:22:21 PM UTC, comment #1: 

The addition of 'AC_SUBST(CXXFLAGS)' to configure.ac is redundant because it is already AC_SUBST'd automatically by AC_PROG_CXX. But it's fine if the maintainer wants it to be explicit.

'AC_SUBST(CPPFLAGS)' is also builtin and could be removed.

Confirmed that if 'configure' is called with CXXFLAGS in the environment, those options are not passed on to the Makefile, and this patch looks like it does the right thing.

Mike Miller <mtmiller>
Group Member
Fri 01 Mar 2019 05:04:27 PM UTC, original submission:  

In the video package, src/Makefile ignores the environment variable CXXFLAGS.  This precludes the inclusion of user- or system-defined flags, for instance, the hardening flags when building a Debian package.  The patch attached to this bug reports fixes the problem.

Rafael Laboissière <rlaboiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #46385:  use-cxxflags.patch added by rlaboiss (920B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by andy1978 (Posted a comment)
  • -email is unavailable- added by rlaboiss (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-11-22 andy1978 Open/ClosedOpen Closed
    2019-03-01 mtmiller StatusNone Patch Submitted
    2019-03-01 rlaboiss Attached File- Added use-cxxflags.patch, #46385

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code