GNU nano - Bugs: bug #54721, after invoking help, the internal...
You are not allowed to post comments on this tracker with your current authentication level.
bug #54721: after invoking help, the internal spell checker no longer spotlights the misspelled word
Submitter: | Benno Schulenberg <bens> | ||
Submitted: | Mon 24 Sep 2018 07:37:29 PM UTC | ||
Severity: | 2 - Minor | Status: | Fixed |
Assigned to: | dolorous | Open/Closed: | Closed |
Jump to the original submission
Wed 10 Oct 2018 05:46:14 PM UTC, comment #9: |
David Lawrence Ramsey <dolorous> |
Tue 09 Oct 2018 06:11:00 PM UTC, comment #8: Ah. I hadn't thought of a help screen being in fact a buffer. :|
|
Benno Schulenberg <bens> |
Tue 09 Oct 2018 01:24:56 PM UTC, comment #7: Okay. Attached a new version that makes the variables global, and resyncs it against git 7ea6d6b.
|
David Lawrence Ramsey <dolorous> |
Mon 08 Oct 2018 03:25:03 PM UTC, comment #6: Hi David,
|
Benno Schulenberg <bens> |
Sat 29 Sep 2018 04:37:38 PM UTC, comment #5: Losing the highlight isn't that minor if you're making a lot of changes, and then forget where you were momentarily.
|
David Lawrence Ramsey <dolorous> |
Sat 29 Sep 2018 07:06:08 AM UTC, comment #4: Okay, the mishighlighting of half a paragraph as the "misspelled word" has been fixed. All that remains is the not re-highlighting of the misspelled word. I don't know whether it is worth trying to fix that. The mishighlighting was an obvious in-your-face error; the not-re-highlighting is a minor inconvenience. |
Benno Schulenberg <bens> |
Wed 26 Sep 2018 05:59:15 PM UTC, comment #3: Sure.
|
David Lawrence Ramsey <dolorous> |
Wed 26 Sep 2018 05:49:26 PM UTC, comment #2: Thanks for the patch. But... it does not keep the spotlighted text highlighted properly. It does avoid erronously highlighting part of the selected text, which is a small improvement, but it does not re-spotlight the misspelled word for which a replacement is being asked. So it makes a marked and unmarked internal spell check behave the same way (which is: droping the spotlight after the help text was invoked), and that is better than two divergent behaviors. So I have pushed your patch anyway: commit bed99717.
|
Benno Schulenberg <bens> |
Tue 25 Sep 2018 12:20:07 AM UTC, comment #1: The attached patch (against git c545438) should keep the marked text highlighted properly, which is half the problem. |
David Lawrence Ramsey <dolorous> |
Mon 24 Sep 2018 07:37:29 PM UTC, original submission:
To reproduce, run 'src/nano --ignore NEWS'. Then type <Ctrl+Shift+Down>. See that the first paragraph is highlighted. Now type ^T for a spell check. See that it highlights the word "comme" and asks on the prompt bar to edit a replacement. Ignore this and type ^G ^X. Oww! Now it highlights not just "comme" but the whole of the first paragraph starting from "comme". :|
|
Benno Schulenberg <bens> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 9 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-11-12 | bens | Open/Closed | Open | Closed | |
2018-10-09 | bens | Status | In Progress | Fixed | |
2018-10-09 | dolorous | Attached File | - | Added nano-highlight.zip, #45168 | |
2018-10-08 | bens | Status | None | In Progress | |
Assigned to | None | dolorous | |||
2018-09-29 | dolorous | Attached File | - | Added nano-highlight.zip, #45118 | |
2018-09-29 | bens | Severity | 3 - Normal | 2 - Minor | |
Summary | after invoking help, the internal spell checker mishighlights things | after invoking help, the internal spell checker no longer spotlights the misspelled word | |||
2018-09-25 | dolorous | Attached File | - | Added 0001-speller-restore-the-mark-coordinates-slightly-later.patch, #45089 |
Powered by Savane 3.13-d3ae.
Corresponding source code
No problem. And yes, I know it's a seldomly used case, but extending spotlighting may very well allow spotlighting to be used elsewhere under similar circumstances in the future :)